Another approach to write netboot-lib #639

pietrushnic · 2024-12-17T23:02:21Z

Current state:

Dasharo (coreboot+UEFI)

Test env preparation:

./scripts/ci/remote-runner.sh user@host . nographic os_install uefi
ssh -t user@host 'cd /tmp/osfv && source venv/bin/activate && ./scripts/ci/qemu-self-test.sh

self-test was moded to execute only self-test/netbootxyz.robot

==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz Menu :: Test Enter Netboot.Xyz Menu kwd             | PASS |
------------------------------------------------------------------------------
Enter Netboot.Xyz Menu And Return Construction :: Test Enter Netbo... | PASS |
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | PASS |
2 tests, 2 passed, 0 failed
==============================================================================
Output:  /tmp/osfv/logs/2024.12.17_23.53.40/nextboot/output.xml
Log:     /tmp/osfv/logs/2024.12.17_23.53.40/nextboot/log.html
Report:  /tmp/osfv/logs/2024.12.17_23.53.40/nextboot/report.html

Dasharo (coreboot+SeaBIOS)

Test env preparation:

./scripts/ci/remote-runner.sh user@host . nographic os_install seabios
ssh -t user@host 'cd /tmp/osfv && source venv/bin/activate && ./scripts/ci/qemu-self-test-seabios.sh

self-test was moded to execute only self-test/netbootxyz.robot

==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz Menu :: Test Enter Netboot.Xyz Menu kwd             | PASS |
------------------------------------------------------------------------------
Enter Netboot.Xyz Menu And Return Construction :: Test Enter Netbo... | PASS |
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | PASS |
2 tests, 2 passed, 0 failed
==============================================================================
Output:  /tmp/osfv/logs/2024.12.17_23.59.28/nextboot/output.xml
Log:     /tmp/osfv/logs/2024.12.17_23.59.28/nextboot/log.html
Report:  /tmp/osfv/logs/2024.12.17_23.59.28/nextboot/report.html

With this PR we should be able to remove two branches:

Obviously there is redundancy here and we should clean this PR first.

Signed-off-by: Piotr Król <[email protected]>

Signed-off-by: Maciej Pijanowski <[email protected]>

Signed-off-by: Piotr Król <[email protected]>

…uction test Signed-off-by: Piotr Król <[email protected]>

… Construction Signed-off-by: Piotr Król <[email protected]>

macpijan

So far looks good, thanks.

The question is if it works further as well - whether it will allow us to enter the menus (and then select OS) we need.

pietrushnic · 2024-12-18T10:23:46Z

@macpijan, that is my goal; please let me know what test you want. I would like to have an Ubuntu installation. Do we also want to boot arbitrary Live distro?

macpijan · 2024-12-18T10:25:42Z

I would like to have an Ubuntu installation

I think it's more than enough if this works.

macpijan · 2024-12-18T10:28:49Z

self-tests/netbootxyz.robot

+Library             RequestsLibrary
+# TODO: maybe have a single file to include if we need to include the same
+# stuff in all test cases
+Resource            ../sonoff-rest-api/sonoff-api.robot


please drop - triggers: Resource file '../sonoff-rest-api/sonoff-api.robot' does not exist.

macpijan · 2024-12-18T10:29:02Z

self-tests/netbootxyz.robot

+# TODO: maybe have a single file to include if we need to include the same
+# stuff in all test cases
+Resource            ../sonoff-rest-api/sonoff-api.robot
+Resource            ../rtectrl-rest-api/rtectrl.robot


as above - we do not use them anymore

macpijan · 2024-12-18T10:38:16Z

Apart from the mentioned errors, strangely enough it does not work for me for UEFI:

 SNIPEIT_NO=true RTE_IP=127.0.0.1 CONFIG=qemu-selftests-uefi  DEVICE_IP=127.0.0.1 ./scripts/run.sh self-tests/netbootxyz.robot
Logs will be saved at logs/qemu-selftests-uefi/2024_12_18_11_35_43
Watch "logs/qemu-selftests-uefi/2024_12_18_11_35_43/self-tests/netbootxyz.robot_debug.log" to monitor the progress of the test
[ ERROR ] Error in file '/home/macpijan/projects/github/dasharo/open-source-firmware-validation/self-tests/netbootxyz.robot' on line 13: Resource file '../sonoff-rest-api/sonoff-api.robot' does not exist.
[ ERROR ] Error in file '/home/macpijan/projects/github/dasharo/open-source-firmware-validation/self-tests/netbootxyz.robot' on line 14: Resource file '../rtectrl-rest-api/rtectrl.robot' does not exist.
==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz Menu :: Test Enter Netboot.Xyz Menu kwd             | FAIL |
No keyword with name 'Enter Boot Menu Tianocore And Return Construction' found. Did you mean:
    edk2.Enter Setup Menu Tianocore And Return Construction
    common.Enter Boot Menu And Return Construction
------------------------------------------------------------------------------
Enter Netboot.Xyz Menu And Return Construction :: Test Enter Netbo... ^CSecond signal will force exit.
Enter Netboot.Xyz Menu And Return Construction :: Test Enter Netbo... | FAIL |
Setup failed:
Execution terminated by signal
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | FAIL |
2 tests, 0 passed, 2 failed
==============================================================================
Debug:   /home/macpijan/projects/github/dasharo/open-source-firmware-validation/logs/qemu-selftests-uefi/2024_12_18_11_35_43/self-tests/netbootxyz.robot_debug.log
Output:  /home/macpijan/projects/github/dasharo/open-source-firmware-validation/logs/qemu-selftests-uefi/2024_12_18_11_35_43/self-tests/netbootxyz.robot_out.xml
Log:     /home/macpijan/projects/github/dasharo/open-source-firmware-validation/logs/qemu-selftests-uefi/2024_12_18_11_35_43/self-tests/netbootxyz.robot_log.html
Report:  /home/macpijan/projects/github/dasharo/open-source-firmware-validation/logs/qemu-selftests-uefi/2024_12_18_11_35_43/self-tests/netbootxyz.robot_report.html

pietrushnic · 2024-12-18T10:43:58Z

Jeez, sorry. I didn't pushed all the changes.

Signed-off-by: Piotr Król <[email protected]>

…edundant kwd Signed-off-by: Piotr Król <[email protected]>

Signed-off-by: Piotr Król <[email protected]>

pietrushnic · 2024-12-18T10:48:27Z

@macpijan, please check now. All those PRs are so convoluted that changes are not logically separated because I'm fixing issues where I find them. To clarify things, we should split my PRs into many and describe those much better. If you have suggestions, please let me know. I know it is currently quite dirty, but at least I'm following the lib structure instead of bling keystrokes and hope for not changing menus.

Signed-off-by: Piotr Król <[email protected]>

macpijan · 2024-12-18T11:10:38Z

Now parsing of the main menu works fine 👍

Signed-off-by: Piotr Król <[email protected]>

pietrushnic · 2024-12-20T00:43:56Z

Now, parsing of the Linux Install menu works. It cost me a couple of hours of work, but I'm so far happy with the results:

==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz Linux Install Menu And Return Construction :: Te... | PASS |
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | PASS |
1 test, 1 passed, 0 failed
==============================================================================

We should have a goo foundation for kicking off any OS installation.

Signed-off-by: Piotr Król <[email protected]>

pietrushnic · 2024-12-20T17:00:08Z

With these changes, I can enter Debian, Ubuntu and Fedora installation menus:

==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz Linux Distro Install Menu And Return Constructio... | PASS |
------------------------------------------------------------------------------
Enter Netboot.Xyz Linux Distro Install Menu And Return Constructio... | PASS |
------------------------------------------------------------------------------
Enter Netboot.Xyz Linux Distro Install Menu And Return Constructio... | PASS |
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | PASS |
3 tests, 3 passed, 0 failed
==============================================================================

Signed-off-by: Piotr Król <[email protected]>

pietrushnic · 2024-12-20T23:40:23Z

Above change allows to set kernel cmdline parameters in Utilities menu:

==============================================================================
Netbootxyz :: This suite verifies the correct operation of keywords parsing...
==============================================================================
Enter Netboot.Xyz And Set Kernel Cmdline Params :: Test Enter Netb... | PASS |
------------------------------------------------------------------------------
Netbootxyz :: This suite verifies the correct operation of keyword... | PASS |
1 test, 1 passed, 0 failed
==============================================================================

pietrushnic and others added 5 commits December 17, 2024 23:32

move relevant keywords to netbootxyz-lib

ece8ffd

Signed-off-by: Piotr Król <[email protected]>

netbootxyz-lib: wip parsing

a6f60e6

Signed-off-by: Maciej Pijanowski <[email protected]>

self-tests/netbootxyz.robot: Enter Netboot.Xyz Menu pass

0d39e97

Signed-off-by: Piotr Król <[email protected]>

self-tests/netbootxyz.robot: Enter Netboot.Xyz Menu And Return Constr…

4cd5dc8

…uction test Signed-off-by: Piotr Król <[email protected]>

self-tests/netbootxyz.robot: finish Enter Netboot.Xyz Menu And Return…

49b5612

… Construction Signed-off-by: Piotr Król <[email protected]>

pietrushnic requested a review from macpijan December 17, 2024 23:02

macpijan reviewed Dec 18, 2024

View reviewed changes

pietrushnic added 4 commits December 18, 2024 11:44

lib/bios/seabios.robot: drop unused Select Boot Menu Option

579384d

Signed-off-by: Piotr Król <[email protected]>

lib/bios: make Select Boot Menu Option more generic

a2025fd

Signed-off-by: Piotr Król <[email protected]>

lib/netbootxyz-lib.robot: correct Enter Netboot.Xyz Menu and remove r…

494ff72

…edundant kwd Signed-off-by: Piotr Król <[email protected]>

self-tests/netbootxyz.robot: drop unused libs

034fc95

Signed-off-by: Piotr Król <[email protected]>

self-tests/os-boot.robot: drop unused libs

021d26c

Signed-off-by: Piotr Król <[email protected]>

pietrushnic added 2 commits December 20, 2024 01:40

lib/bios/seabios.robot: add sanity check if options was set

8b9124d

Signed-off-by: Piotr Król <[email protected]>

lib/netbootxyz-lib.robot: add parsing of Linux Install menu

95f8b5a

Signed-off-by: Piotr Król <[email protected]>

lib/netbootxyz-lib.robot: add parsing of Linux distro install menu

025c897

Signed-off-by: Piotr Król <[email protected]>

lib/netbootxyz-lib.robot: enter utilities and set kernel paramaters

525f667

Signed-off-by: Piotr Król <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Another approach to write netboot-lib #639

Another approach to write netboot-lib #639

pietrushnic commented Dec 17, 2024

macpijan left a comment

pietrushnic commented Dec 18, 2024

macpijan commented Dec 18, 2024

macpijan Dec 18, 2024

pietrushnic Dec 18, 2024

macpijan Dec 18, 2024

pietrushnic Dec 18, 2024

macpijan commented Dec 18, 2024

pietrushnic commented Dec 18, 2024

pietrushnic commented Dec 18, 2024

macpijan commented Dec 18, 2024

pietrushnic commented Dec 20, 2024

pietrushnic commented Dec 20, 2024

pietrushnic commented Dec 20, 2024

Another approach to write netboot-lib #639

Are you sure you want to change the base?

Another approach to write netboot-lib #639

Conversation

pietrushnic commented Dec 17, 2024

Dasharo (coreboot+UEFI)

Dasharo (coreboot+SeaBIOS)

macpijan left a comment

Choose a reason for hiding this comment

pietrushnic commented Dec 18, 2024

macpijan commented Dec 18, 2024

macpijan Dec 18, 2024

Choose a reason for hiding this comment

pietrushnic Dec 18, 2024

Choose a reason for hiding this comment

macpijan Dec 18, 2024

Choose a reason for hiding this comment

pietrushnic Dec 18, 2024

Choose a reason for hiding this comment

macpijan commented Dec 18, 2024

pietrushnic commented Dec 18, 2024

pietrushnic commented Dec 18, 2024

macpijan commented Dec 18, 2024

pietrushnic commented Dec 20, 2024

pietrushnic commented Dec 20, 2024

pietrushnic commented Dec 20, 2024