Clean up static-analysis-server unit tests #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonforal
requested review from
rjcoulter22 and
amaanq
and removed request for
rjcoulter22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The static-analysis-server unit tests are written by manually constructing
ServerRulestructs. This makes test cases harder to author (e.g. one needs to manually convert to base64 and calculate a checksum) and harder to quickly ascertain what data is different between test cases.What is your solution?
DRY up the tests by adding helper functions
Alternatives considered
What the reviewer should know
process_analysis_request(in the tests) was renamed toshorthand_process_reqto disambiguate it.