Fix test flakiness for redisson

DataDog · Sep 10, 2024 · c9ca2e1 · c9ca2e1
1 parent ff190af
commit c9ca2e1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 19 deletions.
diff --git a/...a-agent/instrumentation/redisson/redisson-2.0.0/src/test/groovy/RedissonClientTest.groovy b/...a-agent/instrumentation/redisson/redisson-2.0.0/src/test/groovy/RedissonClientTest.groovy
@@ -1,6 +1,4 @@
-import static datadog.trace.agent.test.utils.TraceUtils.runUnderTrace
 import static datadog.trace.api.config.TraceInstrumentationConfig.DB_CLIENT_HOST_SPLIT_BY_INSTANCE
-import static datadog.trace.bootstrap.instrumentation.api.AgentTracer.activeSpan
 
 import com.redis.testcontainers.RedisContainer
 import com.redis.testcontainers.RedisServer
@@ -54,17 +52,15 @@ abstract class RedissonClientTest extends VersionedNamingTestBase {
   }
 
   def setup() {
-    def cleanupSpan = runUnderTrace("cleanup") {
-      activeSpan()
-    }
-    TEST_WRITER.waitUntilReported(cleanupSpan)
     TEST_WRITER.start()
   }
 
   def cleanup() {
-    RedisConnection conn = lowLevelRedisClient.connect()
-    conn.sync(RedisCommands.FLUSHDB)
-    conn.closeAsync().await()
+    try (def suppressScope = TEST_TRACER.muteTracing()) {
+      RedisConnection conn = lowLevelRedisClient.connect()
+      conn.sync(RedisCommands.FLUSHDB)
+      conn.closeAsync().await()
+    }
   }
 
   def "bucket set command"() {

diff --git a/...a-agent/instrumentation/redisson/redisson-2.3.0/src/test/groovy/RedissonClientTest.groovy b/...a-agent/instrumentation/redisson/redisson-2.3.0/src/test/groovy/RedissonClientTest.groovy
@@ -53,15 +53,13 @@ abstract class RedissonClientTest extends VersionedNamingTestBase {
   }
 
   def setup() {
-    def cleanupSpan = runUnderTrace("cleanup") {
-      activeSpan()
-    }
-    TEST_WRITER.waitUntilReported(cleanupSpan)
     TEST_WRITER.start()
   }
 
   def cleanup() {
-    redissonClient.getKeys().flushdb()
+    try (def suppressScope = TEST_TRACER.muteTracing()) {
+      redissonClient.getKeys().flushdb()
+    }
   }
 
   def "bucket set command"() {

diff --git a/...-agent/instrumentation/redisson/redisson-3.10.3/src/test/groovy/RedissonClientTest.groovy b/...-agent/instrumentation/redisson/redisson-3.10.3/src/test/groovy/RedissonClientTest.groovy
@@ -47,15 +47,13 @@ abstract class RedissonClientTest extends VersionedNamingTestBase {
   }
 
   def setup() {
-    def cleanupSpan = runUnderTrace("cleanup") {
-      activeSpan()
-    }
-    TEST_WRITER.waitUntilReported(cleanupSpan)
     TEST_WRITER.start()
   }
 
   def cleanup() {
-    redissonClient.getKeys().flushdb()
+    try (def suppressScope = TEST_TRACER.muteTracing()) {
+      redissonClient.getKeys().flushdb()
+    }
   }
   def "bucket set command"() {
     when: