Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid instrumentation build when possible #6722

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

smola
Copy link
Member

@smola smola commented Feb 22, 2024

What Does This Do

Apply the same skip logic for build, check and test steps. This should help avoiding building instrumentations when only profiler changed.

Motivation

Additional Notes

@smola smola added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Feb 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Feb 22, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/build-inst-avoidance
git_commit_date 1709113684 1709114305
git_commit_sha d181a4e db13df6
release_version 1.31.0-SNAPSHOT~d181a4ea9d 1.31.0-SNAPSHOT~db13df6f1e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709117595 1709117595
ci_job_id 445554546 445554546
ci_pipeline_id 29101645 29101645
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics.

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-28T10:29:41 2024-02-28T10:48:15
git_branch master smola/build-inst-avoidance
git_commit_date 1709113684 1709114305
git_commit_sha d181a4e db13df6
release_version 1.31.0-SNAPSHOT~d181a4ea9d 1.31.0-SNAPSHOT~db13df6f1e
start_time 2024-02-28T10:29:28 2024-02-28T10:48:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709117595 1709117595
ci_job_id 445554546 445554546
ci_pipeline_id 29101645 29101645
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~db13df6f1e, baseline=1.31.0-SNAPSHOT~d181a4ea9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.093 µs) : 345, 385
.   : milestone, 365,
iast (473.571 µs) : 453, 495
.   : milestone, 474,
iast_FULL (528.628 µs) : 508, 549
.   : milestone, 529,
iast_GLOBAL (497.384 µs) : 476, 519
.   : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (473.915 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (445.694 µs) : 425, 466
.   : milestone, 446,
iast_TELEMETRY_OFF (465.775 µs) : 445, 486
.   : milestone, 466,
tracing (443.325 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (367.476 µs) : 347, 388
.   : milestone, 367,
iast (481.598 µs) : 460, 503
.   : milestone, 482,
iast_FULL (532.783 µs) : 512, 553
.   : milestone, 533,
iast_GLOBAL (502.289 µs) : 482, 523
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (471.549 µs) : 451, 492
.   : milestone, 472,
iast_INACTIVE (438.491 µs) : 418, 459
.   : milestone, 438,
iast_TELEMETRY_OFF (467.829 µs) : 447, 488
.   : milestone, 468,
tracing (440.434 µs) : 420, 461
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 365.093 µs [344.981 µs, 385.205 µs] -
iast 473.571 µs [452.518 µs, 494.624 µs] 108.478 µs (29.7%)
iast_FULL 528.628 µs [508.316 µs, 548.94 µs] 163.535 µs (44.8%)
iast_GLOBAL 497.384 µs [476.171 µs, 518.598 µs] 132.291 µs (36.2%)
iast_HARDCODED_SECRET_DISABLED 473.915 µs [452.538 µs, 495.292 µs] 108.822 µs (29.8%)
iast_INACTIVE 445.694 µs [425.258 µs, 466.129 µs] 80.601 µs (22.1%)
iast_TELEMETRY_OFF 465.775 µs [445.352 µs, 486.199 µs] 100.683 µs (27.6%)
tracing 443.325 µs [422.201 µs, 464.45 µs] 78.233 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.476 µs [347.076 µs, 387.877 µs] -
iast 481.598 µs [460.177 µs, 503.019 µs] 114.122 µs (31.1%)
iast_FULL 532.783 µs [512.475 µs, 553.091 µs] 165.307 µs (45.0%)
iast_GLOBAL 502.289 µs [481.672 µs, 522.906 µs] 134.812 µs (36.7%)
iast_HARDCODED_SECRET_DISABLED 471.549 µs [450.82 µs, 492.279 µs] 104.073 µs (28.3%)
iast_INACTIVE 438.491 µs [418.163 µs, 458.818 µs] 71.014 µs (19.3%)
iast_TELEMETRY_OFF 467.829 µs [447.264 µs, 488.395 µs] 100.353 µs (27.3%)
tracing 440.434 µs [419.658 µs, 461.21 µs] 72.958 µs (19.9%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~db13df6f1e, baseline=1.31.0-SNAPSHOT~d181a4ea9d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1354
.   : milestone, 1335,
appsec (1.784 ms) : 1761, 1808
.   : milestone, 1784,
iast (1.528 ms) : 1505, 1551
.   : milestone, 1528,
profiling (1.551 ms) : 1526, 1576
.   : milestone, 1551,
tracing (1.498 ms) : 1475, 1522
.   : milestone, 1498,
section candidate
no_agent (1.362 ms) : 1344, 1381
.   : milestone, 1362,
appsec (1.784 ms) : 1760, 1807
.   : milestone, 1784,
iast (1.501 ms) : 1478, 1525
.   : milestone, 1501,
profiling (1.547 ms) : 1521, 1572
.   : milestone, 1547,
tracing (1.485 ms) : 1462, 1508
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.316 ms, 1.354 ms] -
appsec 1.784 ms [1.761 ms, 1.808 ms] 449.543 µs (33.7%)
iast 1.528 ms [1.505 ms, 1.551 ms] 193.2 µs (14.5%)
profiling 1.551 ms [1.526 ms, 1.576 ms] 216.112 µs (16.2%)
tracing 1.498 ms [1.475 ms, 1.522 ms] 163.557 µs (12.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.344 ms, 1.381 ms] -
appsec 1.784 ms [1.76 ms, 1.807 ms] 421.032 µs (30.9%)
iast 1.501 ms [1.478 ms, 1.525 ms] 138.989 µs (10.2%)
profiling 1.547 ms [1.521 ms, 1.572 ms] 184.317 µs (13.5%)
tracing 1.485 ms [1.462 ms, 1.508 ms] 122.378 µs (9.0%)

@smola smola force-pushed the smola/build-inst-avoidance branch from 6346a87 to 48b898b Compare February 26, 2024 07:22
@smola smola marked this pull request as ready for review February 26, 2024 07:25
@smola smola requested a review from a team as a code owner February 26, 2024 07:25
@smola smola requested review from mcculls and am312 February 26, 2024 07:25
@smola smola merged commit 323b6ee into master Feb 28, 2024
79 checks passed
@smola smola deleted the smola/build-inst-avoidance branch February 28, 2024 15:29
@github-actions github-actions bot added this to the 1.31.0 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants