-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid instrumentation build when possible #6722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Feb 22, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~db13df6f1e, baseline=1.31.0-SNAPSHOT~d181a4ea9d
dateFormat X
axisFormat %s
section baseline
no_agent (365.093 µs) : 345, 385
. : milestone, 365,
iast (473.571 µs) : 453, 495
. : milestone, 474,
iast_FULL (528.628 µs) : 508, 549
. : milestone, 529,
iast_GLOBAL (497.384 µs) : 476, 519
. : milestone, 497,
iast_HARDCODED_SECRET_DISABLED (473.915 µs) : 453, 495
. : milestone, 474,
iast_INACTIVE (445.694 µs) : 425, 466
. : milestone, 446,
iast_TELEMETRY_OFF (465.775 µs) : 445, 486
. : milestone, 466,
tracing (443.325 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (367.476 µs) : 347, 388
. : milestone, 367,
iast (481.598 µs) : 460, 503
. : milestone, 482,
iast_FULL (532.783 µs) : 512, 553
. : milestone, 533,
iast_GLOBAL (502.289 µs) : 482, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (471.549 µs) : 451, 492
. : milestone, 472,
iast_INACTIVE (438.491 µs) : 418, 459
. : milestone, 438,
iast_TELEMETRY_OFF (467.829 µs) : 447, 488
. : milestone, 468,
tracing (440.434 µs) : 420, 461
. : milestone, 440,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~db13df6f1e, baseline=1.31.0-SNAPSHOT~d181a4ea9d
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1354
. : milestone, 1335,
appsec (1.784 ms) : 1761, 1808
. : milestone, 1784,
iast (1.528 ms) : 1505, 1551
. : milestone, 1528,
profiling (1.551 ms) : 1526, 1576
. : milestone, 1551,
tracing (1.498 ms) : 1475, 1522
. : milestone, 1498,
section candidate
no_agent (1.362 ms) : 1344, 1381
. : milestone, 1362,
appsec (1.784 ms) : 1760, 1807
. : milestone, 1784,
iast (1.501 ms) : 1478, 1525
. : milestone, 1501,
profiling (1.547 ms) : 1521, 1572
. : milestone, 1547,
tracing (1.485 ms) : 1462, 1508
. : milestone, 1485,
|
smola
force-pushed
the
smola/build-inst-avoidance
branch
from
February 26, 2024 07:22
6346a87
to
48b898b
Compare
am312
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Apply the same skip logic for build, check and test steps. This should help avoiding building instrumentations when only profiler changed.
Motivation
Additional Notes