add JAVA_21_HOME env var #6759

am312 · 2024-02-28T16:20:49Z

What Does This Do

Adds JAVA_21_HOME env var requirement

Motivation

JDK-21 compilation is now required.

pr-commenter · 2024-02-28T17:14:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrew.munn/add-java-21-home
git_commit_date	1709134307	1709137189
git_commit_sha	`f04d01f`	`118e707`
release_version	1.31.0-SNAPSHOT~f04d01f83b	1.31.0-SNAPSHOT~118e70757f

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1709140417	1709140417
ci_job_id	446071276	446071276
ci_pipeline_id	29134359	29134359
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~118e70757f, baseline=1.31.0-SNAPSHOT~f04d01f83b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078650
Total [baseline] (9.146 s) : 0, 9146364
Agent [candidate] (1.095 s) : 0, 1095056
Total [candidate] (9.286 s) : 0, 9285750
section appsec
Agent [baseline] (1.185 s) : 0, 1184806
Total [baseline] (9.326 s) : 0, 9326122
Agent [candidate] (1.185 s) : 0, 1185492
Total [candidate] (9.369 s) : 0, 9369376
section iast
Agent [baseline] (1.204 s) : 0, 1204113
Total [baseline] (9.329 s) : 0, 9329378
Agent [candidate] (1.207 s) : 0, 1207135
Total [candidate] (9.33 s) : 0, 9330201
section profiling
Agent [baseline] (1.269 s) : 0, 1269237
Total [baseline] (9.327 s) : 0, 9327486
Agent [candidate] (1.282 s) : 0, 1281900
Total [candidate] (9.345 s) : 0, 9344507

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	appsec	1.185 s	106.156 ms (9.8%)
Agent	iast	1.204 s	125.463 ms (11.6%)
Agent	profiling	1.269 s	190.588 ms (17.7%)
Total	tracing	9.146 s	-
Total	appsec	9.326 s	179.758 ms (2.0%)
Total	iast	9.329 s	183.014 ms (2.0%)
Total	profiling	9.327 s	181.122 ms (2.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.185 s	90.436 ms (8.3%)
Agent	iast	1.207 s	112.079 ms (10.2%)
Agent	profiling	1.282 s	186.843 ms (17.1%)
Total	tracing	9.286 s	-
Total	appsec	9.369 s	83.627 ms (0.9%)
Total	iast	9.33 s	44.451 ms (0.5%)
Total	profiling	9.345 s	58.757 ms (0.6%)

gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~118e70757f, baseline=1.31.0-SNAPSHOT~f04d01f83b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.62 ms) : 0, 687620
BytebuddyAgent [candidate] (698.315 ms) : 0, 698315
GlobalTracer [baseline] (296.997 ms) : 0, 296997
GlobalTracer [candidate] (301.347 ms) : 0, 301347
AppSec [baseline] (51.143 ms) : 0, 51143
AppSec [candidate] (51.878 ms) : 0, 51878
Remote Config [baseline] (708.309 µs) : 0, 708
Remote Config [candidate] (721.7 µs) : 0, 722
Telemetry [baseline] (7.773 ms) : 0, 7773
Telemetry [candidate] (7.921 ms) : 0, 7921
section appsec
BytebuddyAgent [baseline] (692.112 ms) : 0, 692112
BytebuddyAgent [candidate] (692.172 ms) : 0, 692172
GlobalTracer [baseline] (298.318 ms) : 0, 298318
GlobalTracer [candidate] (299.46 ms) : 0, 299460
AppSec [baseline] (152.222 ms) : 0, 152222
AppSec [candidate] (151.606 ms) : 0, 151606
Remote Config [baseline] (646.367 µs) : 0, 646
Remote Config [candidate] (646.211 µs) : 0, 646
Telemetry [baseline] (6.98 ms) : 0, 6980
Telemetry [candidate] (6.992 ms) : 0, 6992
section iast
BytebuddyAgent [baseline] (798.932 ms) : 0, 798932
BytebuddyAgent [candidate] (800.386 ms) : 0, 800386
GlobalTracer [baseline] (288.803 ms) : 0, 288803
GlobalTracer [candidate] (289.185 ms) : 0, 289185
AppSec [baseline] (51.462 ms) : 0, 51462
AppSec [candidate] (52.731 ms) : 0, 52731
Remote Config [baseline] (599.975 µs) : 0, 600
Remote Config [candidate] (601.1 µs) : 0, 601
Telemetry [baseline] (7.488 ms) : 0, 7488
Telemetry [candidate] (7.45 ms) : 0, 7450
IAST [baseline] (22.553 ms) : 0, 22553
IAST [candidate] (22.549 ms) : 0, 22549
section profiling
BytebuddyAgent [baseline] (677.639 ms) : 0, 677639
BytebuddyAgent [candidate] (684.598 ms) : 0, 684598
GlobalTracer [baseline] (379.374 ms) : 0, 379374
GlobalTracer [candidate] (382.558 ms) : 0, 382558
AppSec [baseline] (52.949 ms) : 0, 52949
AppSec [candidate] (53.374 ms) : 0, 53374
Remote Config [baseline] (787.754 µs) : 0, 788
Remote Config [candidate] (776.954 µs) : 0, 777
Telemetry [baseline] (9.636 ms) : 0, 9636
Telemetry [candidate] (8.434 ms) : 0, 8434
ProfilingAgent [baseline] (92.906 ms) : 0, 92906
ProfilingAgent [candidate] (95.553 ms) : 0, 95553
Profiling [baseline] (92.93 ms) : 0, 92930
Profiling [candidate] (95.576 ms) : 0, 95576

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-02-28T16:49:58	2024-02-28T17:08:38
git_branch	master	andrew.munn/add-java-21-home
git_commit_date	1709134307	1709137189
git_commit_sha	`f04d01f`	`118e707`
release_version	1.31.0-SNAPSHOT~f04d01f83b	1.31.0-SNAPSHOT~118e70757f
start_time	2024-02-28T16:49:45	2024-02-28T17:08:25

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1709140417	1709140417
ci_job_id	446071276	446071276
ci_pipeline_id	29134359	29134359
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~118e70757f, baseline=1.31.0-SNAPSHOT~f04d01f83b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.361 ms) : 1342, 1380
.   : milestone, 1361,
appsec (1.768 ms) : 1745, 1792
.   : milestone, 1768,
iast (1.501 ms) : 1478, 1524
.   : milestone, 1501,
profiling (1.544 ms) : 1520, 1569
.   : milestone, 1544,
tracing (1.507 ms) : 1483, 1531
.   : milestone, 1507,
section candidate
no_agent (1.349 ms) : 1330, 1367
.   : milestone, 1349,
appsec (1.789 ms) : 1766, 1813
.   : milestone, 1789,
iast (1.501 ms) : 1478, 1524
.   : milestone, 1501,
profiling (1.528 ms) : 1504, 1551
.   : milestone, 1528,
tracing (1.507 ms) : 1483, 1530
.   : milestone, 1507,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.361 ms [1.342 ms, 1.38 ms]	-
appsec	1.768 ms [1.745 ms, 1.792 ms]	407.269 µs (29.9%)
iast	1.501 ms [1.478 ms, 1.524 ms]	139.919 µs (10.3%)
profiling	1.544 ms [1.52 ms, 1.569 ms]	183.289 µs (13.5%)
tracing	1.507 ms [1.483 ms, 1.531 ms]	145.895 µs (10.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.33 ms, 1.367 ms]	-
appsec	1.789 ms [1.766 ms, 1.813 ms]	440.77 µs (32.7%)
iast	1.501 ms [1.478 ms, 1.524 ms]	152.462 µs (11.3%)
profiling	1.528 ms [1.504 ms, 1.551 ms]	178.994 µs (13.3%)
tracing	1.507 ms [1.483 ms, 1.53 ms]	158.236 µs (11.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~118e70757f, baseline=1.31.0-SNAPSHOT~f04d01f83b
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.398 µs) : 344, 383
.   : milestone, 363,
iast (480.965 µs) : 460, 502
.   : milestone, 481,
iast_FULL (540.882 µs) : 521, 561
.   : milestone, 541,
iast_GLOBAL (495.474 µs) : 475, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (472.07 µs) : 452, 492
.   : milestone, 472,
iast_INACTIVE (449.949 µs) : 430, 470
.   : milestone, 450,
iast_TELEMETRY_OFF (468.513 µs) : 448, 489
.   : milestone, 469,
tracing (442.573 µs) : 422, 463
.   : milestone, 443,
section candidate
no_agent (363.951 µs) : 344, 384
.   : milestone, 364,
iast (471.367 µs) : 451, 492
.   : milestone, 471,
iast_FULL (542.371 µs) : 522, 563
.   : milestone, 542,
iast_GLOBAL (495.209 µs) : 475, 516
.   : milestone, 495,
iast_HARDCODED_SECRET_DISABLED (478.322 µs) : 458, 499
.   : milestone, 478,
iast_INACTIVE (451.263 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (474.177 µs) : 453, 495
.   : milestone, 474,
tracing (442.815 µs) : 422, 464
.   : milestone, 443,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	363.398 µs [343.707 µs, 383.088 µs]	-
iast	480.965 µs [459.506 µs, 502.424 µs]	117.567 µs (32.4%)
iast_FULL	540.882 µs [520.525 µs, 561.239 µs]	177.485 µs (48.8%)
iast_GLOBAL	495.474 µs [475.247 µs, 515.701 µs]	132.076 µs (36.3%)
iast_HARDCODED_SECRET_DISABLED	472.07 µs [451.753 µs, 492.388 µs]	108.673 µs (29.9%)
iast_INACTIVE	449.949 µs [429.562 µs, 470.336 µs]	86.551 µs (23.8%)
iast_TELEMETRY_OFF	468.513 µs [448.036 µs, 488.989 µs]	105.115 µs (28.9%)
tracing	442.573 µs [422.072 µs, 463.074 µs]	79.175 µs (21.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	363.951 µs [344.171 µs, 383.732 µs]	-
iast	471.367 µs [450.962 µs, 491.772 µs]	107.415 µs (29.5%)
iast_FULL	542.371 µs [521.991 µs, 562.75 µs]	178.419 µs (49.0%)
iast_GLOBAL	495.209 µs [474.639 µs, 515.779 µs]	131.258 µs (36.1%)
iast_HARDCODED_SECRET_DISABLED	478.322 µs [457.578 µs, 499.066 µs]	114.37 µs (31.4%)
iast_INACTIVE	451.263 µs [430.825 µs, 471.701 µs]	87.311 µs (24.0%)
iast_TELEMETRY_OFF	474.177 µs [453.162 µs, 495.191 µs]	110.225 µs (30.3%)
tracing	442.815 µs [422.108 µs, 463.522 µs]	78.863 µs (21.7%)

add JAVA_21_HOME

118e707

am312 added the tag: no release notes Changes to exclude from release notes label Feb 28, 2024

am312 marked this pull request as ready for review February 28, 2024 16:29

am312 requested a review from a team as a code owner February 28, 2024 16:29

am312 requested review from dougqh and PerfectSlayer February 28, 2024 16:29

smola approved these changes Feb 28, 2024

View reviewed changes

am312 merged commit fc99160 into master Feb 28, 2024
81 checks passed

am312 deleted the andrew.munn/add-java-21-home branch February 28, 2024 19:45

github-actions bot added this to the 1.31.0 milestone Feb 28, 2024

PerfectSlayer added the type: documentation label Feb 29, 2024

jandro996 pushed a commit that referenced this pull request Feb 29, 2024

add JAVA_21_HOME (#6759)

9684136

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add JAVA_21_HOME env var #6759

add JAVA_21_HOME env var #6759

am312 commented Feb 28, 2024

pr-commenter bot commented Feb 28, 2024

add JAVA_21_HOME env var #6759

add JAVA_21_HOME env var #6759

Conversation

am312 commented Feb 28, 2024

What Does This Do

Motivation

pr-commenter bot commented Feb 28, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary