Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure span links trace ids and attributes can't be null #6766

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Mar 1, 2024

What Does This Do

Make sure span links trace ids and attributes can't be null.

Motivation

Follow up PR of #6758

Additional Notes

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added the comp: core Tracer core label Mar 1, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner March 1, 2024 10:43
@PerfectSlayer PerfectSlayer requested review from mcculls and am312 March 1, 2024 10:43
@pr-commenter
Copy link

pr-commenter bot commented Mar 1, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/span-links
git_commit_date 1709301996 1709302174
git_commit_sha 31e5b49 72d8004
release_version 1.31.0-SNAPSHOT~31e5b492f6 1.31.0-SNAPSHOT~72d80043b9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709304999 1709304999
ci_job_id 448218531 448218531
ci_pipeline_id 29293688 29293688
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 41 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:GlobalTracer worse
[+5.982ms; +8.944ms] or [+2.055%; +3.073%]
298.526ms 291.063ms
scenario:startup:petclinic:appsec:Remote Config worse
[+28.704µs; +56.602µs] or [+4.745%; +9.357%]
647.559µs 604.905µs

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-03-01T14:33:05 2024-03-01T14:51:39
git_branch master bbujon/span-links
git_commit_date 1709301996 1709302174
git_commit_sha 31e5b49 72d8004
release_version 1.31.0-SNAPSHOT~31e5b492f6 1.31.0-SNAPSHOT~72d80043b9
start_time 2024-03-01T14:32:52 2024-03-01T14:51:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1709304999 1709304999
ci_job_id 448218531 448218531
ci_pipeline_id 29293688 29293688
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~72d80043b9, baseline=1.31.0-SNAPSHOT~31e5b492f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.775 µs) : 344, 384
.   : milestone, 364,
iast (474.343 µs) : 454, 495
.   : milestone, 474,
iast_FULL (529.281 µs) : 509, 550
.   : milestone, 529,
iast_GLOBAL (490.86 µs) : 470, 512
.   : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (473.031 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (447.513 µs) : 427, 468
.   : milestone, 448,
iast_TELEMETRY_OFF (467.092 µs) : 446, 488
.   : milestone, 467,
tracing (440.56 µs) : 421, 460
.   : milestone, 441,
section candidate
no_agent (367.519 µs) : 348, 387
.   : milestone, 368,
iast (472.111 µs) : 452, 492
.   : milestone, 472,
iast_FULL (537.806 µs) : 517, 558
.   : milestone, 538,
iast_GLOBAL (491.35 µs) : 471, 512
.   : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (476.471 µs) : 456, 497
.   : milestone, 476,
iast_INACTIVE (440.329 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (470.212 µs) : 449, 492
.   : milestone, 470,
tracing (436.425 µs) : 416, 457
.   : milestone, 436,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.775 µs [343.949 µs, 383.601 µs] -
iast 474.343 µs [453.711 µs, 494.975 µs] 110.568 µs (30.4%)
iast_FULL 529.281 µs [508.94 µs, 549.621 µs] 165.506 µs (45.5%)
iast_GLOBAL 490.86 µs [469.84 µs, 511.879 µs] 127.085 µs (34.9%)
iast_HARDCODED_SECRET_DISABLED 473.031 µs [452.102 µs, 493.96 µs] 109.256 µs (30.0%)
iast_INACTIVE 447.513 µs [426.772 µs, 468.254 µs] 83.738 µs (23.0%)
iast_TELEMETRY_OFF 467.092 µs [446.129 µs, 488.056 µs] 103.317 µs (28.4%)
tracing 440.56 µs [420.756 µs, 460.363 µs] 76.785 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.519 µs [347.826 µs, 387.212 µs] -
iast 472.111 µs [451.784 µs, 492.438 µs] 104.592 µs (28.5%)
iast_FULL 537.806 µs [517.463 µs, 558.148 µs] 170.287 µs (46.3%)
iast_GLOBAL 491.35 µs [470.594 µs, 512.106 µs] 123.831 µs (33.7%)
iast_HARDCODED_SECRET_DISABLED 476.471 µs [455.969 µs, 496.973 µs] 108.952 µs (29.6%)
iast_INACTIVE 440.329 µs [420.021 µs, 460.637 µs] 72.81 µs (19.8%)
iast_TELEMETRY_OFF 470.212 µs [448.686 µs, 491.738 µs] 102.693 µs (27.9%)
tracing 436.425 µs [415.857 µs, 456.993 µs] 68.906 µs (18.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~72d80043b9, baseline=1.31.0-SNAPSHOT~31e5b492f6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.78 ms) : 1756, 1803
.   : milestone, 1780,
iast (1.524 ms) : 1501, 1548
.   : milestone, 1524,
profiling (1.532 ms) : 1508, 1556
.   : milestone, 1532,
tracing (1.524 ms) : 1501, 1547
.   : milestone, 1524,
section candidate
no_agent (1.333 ms) : 1314, 1352
.   : milestone, 1333,
appsec (1.775 ms) : 1751, 1798
.   : milestone, 1775,
iast (1.534 ms) : 1511, 1558
.   : milestone, 1534,
profiling (1.58 ms) : 1555, 1604
.   : milestone, 1580,
tracing (1.497 ms) : 1473, 1520
.   : milestone, 1497,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.35 ms [1.331 ms, 1.369 ms] -
appsec 1.78 ms [1.756 ms, 1.803 ms] 429.728 µs (31.8%)
iast 1.524 ms [1.501 ms, 1.548 ms] 174.484 µs (12.9%)
profiling 1.532 ms [1.508 ms, 1.556 ms] 181.998 µs (13.5%)
tracing 1.524 ms [1.501 ms, 1.547 ms] 174.271 µs (12.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.352 ms] -
appsec 1.775 ms [1.751 ms, 1.798 ms] 441.693 µs (33.1%)
iast 1.534 ms [1.511 ms, 1.558 ms] 201.202 µs (15.1%)
profiling 1.58 ms [1.555 ms, 1.604 ms] 246.555 µs (18.5%)
tracing 1.497 ms [1.473 ms, 1.52 ms] 163.67 µs (12.3%)

@PerfectSlayer PerfectSlayer enabled auto-merge (squash) March 1, 2024 14:12
@PerfectSlayer PerfectSlayer merged commit f3b2466 into master Mar 1, 2024
79 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/span-links branch March 1, 2024 15:05
@github-actions github-actions bot added this to the 1.31.0 milestone Mar 1, 2024
@PerfectSlayer PerfectSlayer changed the title Ensure span links attributes can't be null Ensure span links trace ids and attributes can't be null Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants