-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure span links trace ids and attributes can't be null #6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 41 metrics, 11 unstable metrics.
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~72d80043b9, baseline=1.31.0-SNAPSHOT~31e5b492f6
dateFormat X
axisFormat %s
section baseline
no_agent (363.775 µs) : 344, 384
. : milestone, 364,
iast (474.343 µs) : 454, 495
. : milestone, 474,
iast_FULL (529.281 µs) : 509, 550
. : milestone, 529,
iast_GLOBAL (490.86 µs) : 470, 512
. : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (473.031 µs) : 452, 494
. : milestone, 473,
iast_INACTIVE (447.513 µs) : 427, 468
. : milestone, 448,
iast_TELEMETRY_OFF (467.092 µs) : 446, 488
. : milestone, 467,
tracing (440.56 µs) : 421, 460
. : milestone, 441,
section candidate
no_agent (367.519 µs) : 348, 387
. : milestone, 368,
iast (472.111 µs) : 452, 492
. : milestone, 472,
iast_FULL (537.806 µs) : 517, 558
. : milestone, 538,
iast_GLOBAL (491.35 µs) : 471, 512
. : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (476.471 µs) : 456, 497
. : milestone, 476,
iast_INACTIVE (440.329 µs) : 420, 461
. : milestone, 440,
iast_TELEMETRY_OFF (470.212 µs) : 449, 492
. : milestone, 470,
tracing (436.425 µs) : 416, 457
. : milestone, 436,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~72d80043b9, baseline=1.31.0-SNAPSHOT~31e5b492f6
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1369
. : milestone, 1350,
appsec (1.78 ms) : 1756, 1803
. : milestone, 1780,
iast (1.524 ms) : 1501, 1548
. : milestone, 1524,
profiling (1.532 ms) : 1508, 1556
. : milestone, 1532,
tracing (1.524 ms) : 1501, 1547
. : milestone, 1524,
section candidate
no_agent (1.333 ms) : 1314, 1352
. : milestone, 1333,
appsec (1.775 ms) : 1751, 1798
. : milestone, 1775,
iast (1.534 ms) : 1511, 1558
. : milestone, 1534,
profiling (1.58 ms) : 1555, 1604
. : milestone, 1580,
tracing (1.497 ms) : 1473, 1520
. : milestone, 1497,
|
am312
approved these changes
Mar 1, 2024
PerfectSlayer
force-pushed
the
bbujon/span-links
branch
from
March 1, 2024 14:10
f49c244
to
72d8004
Compare
PerfectSlayer
changed the title
Ensure span links attributes can't be null
Ensure span links trace ids and attributes can't be null
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Make sure span links trace ids and attributes can't be
null
.Motivation
Follow up PR of #6758
Additional Notes
Jira ticket: [PROJ-IDENT]