Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🍒 7657] Reduce log level for "WAF object had not been closed" #7667

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[🍒 7657] Reduce log level for "WAF object had not been closed" #7667

merged 1 commit into from
Sep 23, 2024

Conversation

smola
Copy link
Member

@smola smola commented Sep 23, 2024 •
edited
Loading

What Does This Do

(cherry picked from commit 7f040c5)

(#7657)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@smola smola added type: enhancement comp: asm waf Application Security Management (WAF) labels Sep 23, 2024
@smola smola requested a review from a team as a code owner September 23, 2024 13:56
@smola smola changed the base branch from master to release/v1.39.x September 23, 2024 13:57
@smola smola added this to the 1.39.1 milestone Sep 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 23, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/backport-7657
git_commit_date 1727095368 1727099721
git_commit_sha 27f522f c6196ff
release_version 1.40.0-SNAPSHOT~27f522f863 1.40.0-SNAPSHOT~c6196ffb81
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727102027 1727102027
ci_job_id 648187077 648187077
ci_pipeline_id 44912078 44912078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 3 performance improvements and 4 performance regressions! Performance is the same for 41 metrics, 15 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry worse
[+324.204µs; +505.059µs] or [+4.725%; +7.361%]		 7.275ms 6.861ms
scenario:startup:insecure-bank:tracing:AppSec better
[-1.922ms; -1.247ms] or [-3.597%; -2.332%]		 51.863ms 53.448ms
scenario:startup:insecure-bank:tracing:Remote Config worse
[+26.162µs; +53.726µs] or [+3.977%; +8.167%]		 697.752µs 657.808µs
scenario:startup:petclinic:profiling:AppSec better
[-2.709ms; -1.953ms] or [-4.979%; -3.589%]		 52.073ms 54.403ms
scenario:startup:petclinic:profiling:Remote Config worse
[+32.879µs; +58.383µs] or [+5.052%; +8.970%]		 696.474µs 650.843µs
scenario:startup:petclinic:tracing:AppSec better
[-2.818ms; -1.177ms] or [-5.226%; -2.183%]		 51.928ms 53.926ms
scenario:startup:petclinic:tracing:Remote Config worse
[+17.863µs; +57.272µs] or [+2.702%; +8.662%]		 698.745µs 661.178µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068546
Total [baseline] (10.388 s) : 0, 10387580
Agent [candidate] (1.067 s) : 0, 1067039
Total [candidate] (10.372 s) : 0, 10371544
section appsec
Agent [baseline] (1.206 s) : 0, 1205562
Total [baseline] (10.65 s) : 0, 10650051
Agent [candidate] (1.195 s) : 0, 1195483
Total [candidate] (10.551 s) : 0, 10551193
section iast
Agent [baseline] (1.188 s) : 0, 1188086
Total [baseline] (10.906 s) : 0, 10905677
Agent [candidate] (1.19 s) : 0, 1189937
Total [candidate] (10.864 s) : 0, 10863882
section profiling
Agent [baseline] (1.264 s) : 0, 1263726
Total [baseline] (10.57 s) : 0, 10570299
Agent [candidate] (1.259 s) : 0, 1259175
Total [candidate] (10.532 s) : 0, 10532219
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.206 s 137.016 ms (12.8%)
Agent iast 1.188 s 119.54 ms (11.2%)
Agent profiling 1.264 s 195.18 ms (18.3%)
Total tracing 10.388 s -
Total appsec 10.65 s 262.471 ms (2.5%)
Total iast 10.906 s 518.097 ms (5.0%)
Total profiling 10.57 s 182.719 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.195 s 128.444 ms (12.0%)
Agent iast 1.19 s 122.898 ms (11.5%)
Agent profiling 1.259 s 192.135 ms (18.0%)
Total tracing 10.372 s -
Total appsec 10.551 s 179.649 ms (1.7%)
Total iast 10.864 s 492.338 ms (4.7%)
Total profiling 10.532 s 160.676 ms (1.5%) 
gantt
    title petclinic - break down per module: candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.663 ms) : 0, 682663
BytebuddyAgent [candidate] (681.716 ms) : 0, 681716
GlobalTracer [baseline] (310.075 ms) : 0, 310075
GlobalTracer [candidate] (311.454 ms) : 0, 311454
AppSec [baseline] (53.926 ms) : 0, 53926
AppSec [candidate] (51.928 ms) : 0, 51928
Remote Config [baseline] (661.178 µs) : 0, 661
Remote Config [candidate] (698.745 µs) : 0, 699
Telemetry [baseline] (7.586 ms) : 0, 7586
Telemetry [candidate] (7.535 ms) : 0, 7535
section appsec
BytebuddyAgent [baseline] (704.519 ms) : 0, 704519
BytebuddyAgent [candidate] (698.025 ms) : 0, 698025
GlobalTracer [baseline] (304.134 ms) : 0, 304134
GlobalTracer [candidate] (303.633 ms) : 0, 303633
AppSec [baseline] (164.285 ms) : 0, 164285
AppSec [candidate] (160.084 ms) : 0, 160084
IAST [baseline] (20.412 ms) : 0, 20412
IAST [candidate] (19.991 ms) : 0, 19991
Remote Config [baseline] (636.851 µs) : 0, 637
Remote Config [candidate] (640.847 µs) : 0, 641
Telemetry [baseline] (8.157 ms) : 0, 8157
Telemetry [candidate] (9.448 ms) : 0, 9448
section iast
BytebuddyAgent [baseline] (790.714 ms) : 0, 790714
BytebuddyAgent [candidate] (791.813 ms) : 0, 791813
GlobalTracer [baseline] (298.184 ms) : 0, 298184
GlobalTracer [candidate] (299.475 ms) : 0, 299475
AppSec [baseline] (55.926 ms) : 0, 55926
AppSec [candidate] (52.431 ms) : 0, 52431
IAST [baseline] (22.009 ms) : 0, 22009
IAST [candidate] (23.79 ms) : 0, 23790
Remote Config [baseline] (605.145 µs) : 0, 605
Remote Config [candidate] (594.395 µs) : 0, 594
Telemetry [baseline] (7.064 ms) : 0, 7064
Telemetry [candidate] (8.175 ms) : 0, 8175
section profiling
BytebuddyAgent [baseline] (672.793 ms) : 0, 672793
BytebuddyAgent [candidate] (671.451 ms) : 0, 671451
GlobalTracer [baseline] (393.696 ms) : 0, 393696
GlobalTracer [candidate] (393.501 ms) : 0, 393501
AppSec [baseline] (54.403 ms) : 0, 54403
AppSec [candidate] (52.073 ms) : 0, 52073
Remote Config [baseline] (650.843 µs) : 0, 651
Remote Config [candidate] (696.474 µs) : 0, 696
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.42 ms) : 0, 7420
ProfilingAgent [baseline] (96.337 ms) : 0, 96337
ProfilingAgent [candidate] (96.137 ms) : 0, 96137
Profiling [baseline] (96.361 ms) : 0, 96361
Profiling [candidate] (96.161 ms) : 0, 96161
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062847
Total [baseline] (8.528 s) : 0, 8528078
Agent [candidate] (1.06 s) : 0, 1060493
Total [candidate] (8.507 s) : 0, 8506609
section iast
Agent [baseline] (1.196 s) : 0, 1196382
Total [baseline] (8.984 s) : 0, 8983672
Agent [candidate] (1.193 s) : 0, 1192636
Total [candidate] (8.99 s) : 0, 8990189
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.19 s) : 0, 1190373
Total [baseline] (8.973 s) : 0, 8972611
Agent [candidate] (1.184 s) : 0, 1183637
Total [candidate] (8.963 s) : 0, 8962759
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184424
Total [baseline] (8.978 s) : 0, 8977603
Agent [candidate] (1.183 s) : 0, 1182615
Total [candidate] (8.973 s) : 0, 8972906
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.196 s 133.535 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.19 s 127.526 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.184 s 121.577 ms (11.4%)
Total tracing 8.528 s -
Total iast 8.984 s 455.593 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.973 s 444.532 ms (5.2%)
Total iast_TELEMETRY_OFF 8.978 s 449.524 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.193 s 132.143 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 123.144 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.183 s 122.122 ms (11.5%)
Total tracing 8.507 s -
Total iast 8.99 s 483.58 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.963 s 456.15 ms (5.4%)
Total iast_TELEMETRY_OFF 8.973 s 466.297 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (678.875 ms) : 0, 678875
BytebuddyAgent [candidate] (677.075 ms) : 0, 677075
GlobalTracer [baseline] (308.6 ms) : 0, 308600
GlobalTracer [candidate] (309.702 ms) : 0, 309702
AppSec [baseline] (53.448 ms) : 0, 53448
AppSec [candidate] (51.863 ms) : 0, 51863
Remote Config [baseline] (657.808 µs) : 0, 658
Remote Config [candidate] (697.752 µs) : 0, 698
Telemetry [baseline] (7.592 ms) : 0, 7592
Telemetry [candidate] (7.529 ms) : 0, 7529
section iast
BytebuddyAgent [baseline] (796.509 ms) : 0, 796509
BytebuddyAgent [candidate] (794.202 ms) : 0, 794202
GlobalTracer [baseline] (299.784 ms) : 0, 299784
GlobalTracer [candidate] (299.542 ms) : 0, 299542
AppSec [baseline] (54.355 ms) : 0, 54355
AppSec [candidate] (50.957 ms) : 0, 50957
IAST [baseline] (24.307 ms) : 0, 24307
IAST [candidate] (25.483 ms) : 0, 25483
Remote Config [baseline] (837.39 µs) : 0, 837
Remote Config [candidate] (609.139 µs) : 0, 609
Telemetry [baseline] (6.909 ms) : 0, 6909
Telemetry [candidate] (8.146 ms) : 0, 8146
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (792.235 ms) : 0, 792235
BytebuddyAgent [candidate] (786.78 ms) : 0, 786780
GlobalTracer [baseline] (298.403 ms) : 0, 298403
GlobalTracer [candidate] (298.125 ms) : 0, 298125
AppSec [baseline] (52.431 ms) : 0, 52431
AppSec [candidate] (51.503 ms) : 0, 51503
IAST [baseline] (25.965 ms) : 0, 25965
IAST [candidate] (24.77 ms) : 0, 24770
Remote Config [baseline] (643.336 µs) : 0, 643
Remote Config [candidate] (612.32 µs) : 0, 612
Telemetry [baseline] (7.035 ms) : 0, 7035
Telemetry [candidate] (8.231 ms) : 0, 8231
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.457 ms) : 0, 787457
BytebuddyAgent [candidate] (786.229 ms) : 0, 786229
GlobalTracer [baseline] (298.007 ms) : 0, 298007
GlobalTracer [candidate] (298.522 ms) : 0, 298522
AppSec [baseline] (55.603 ms) : 0, 55603
AppSec [candidate] (54.75 ms) : 0, 54750
IAST [baseline] (22.293 ms) : 0, 22293
IAST [candidate] (21.551 ms) : 0, 21551
Remote Config [baseline] (593.896 µs) : 0, 594
Remote Config [candidate] (593.105 µs) : 0, 593
Telemetry [baseline] (6.861 ms) : 0, 6861
Telemetry [candidate] (7.275 ms) : 0, 7275
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-09-23T14:04:26 2024-09-23T14:11:16
git_branch master smola/backport-7657
git_commit_date 1727095368 1727099721
git_commit_sha 27f522f c6196ff
release_version 1.40.0-SNAPSHOT~27f522f863 1.40.0-SNAPSHOT~c6196ffb81
start_time 2024-09-23T14:04:12 2024-09-23T14:11:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1727101022 1727101022
ci_job_id 648187078 648187078
ci_pipeline_id 44912078 44912078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.076 µs) : 357, 397
.   : milestone, 377,
iast (485.498 µs) : 464, 507
.   : milestone, 485,
iast_FULL (559.96 µs) : 538, 582
.   : milestone, 560,
iast_GLOBAL (505.195 µs) : 484, 526
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (492.303 µs) : 471, 514
.   : milestone, 492,
iast_INACTIVE (447.384 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (481.395 µs) : 459, 504
.   : milestone, 481,
tracing (444.42 µs) : 424, 465
.   : milestone, 444,
section candidate
no_agent (370.661 µs) : 351, 391
.   : milestone, 371,
iast (483.964 µs) : 462, 506
.   : milestone, 484,
iast_FULL (560.991 µs) : 540, 582
.   : milestone, 561,
iast_GLOBAL (505.556 µs) : 485, 527
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (487.076 µs) : 465, 509
.   : milestone, 487,
iast_INACTIVE (449.162 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (472.809 µs) : 451, 495
.   : milestone, 473,
tracing (444.85 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.076 µs [356.901 µs, 397.252 µs] -
iast 485.498 µs [464.366 µs, 506.631 µs] 108.422 µs (28.8%)
iast_FULL 559.96 µs [538.364 µs, 581.555 µs] 182.883 µs (48.5%)
iast_GLOBAL 505.195 µs [484.34 µs, 526.05 µs] 128.119 µs (34.0%)
iast_HARDCODED_SECRET_DISABLED 492.303 µs [470.897 µs, 513.71 µs] 115.227 µs (30.6%)
iast_INACTIVE 447.384 µs [426.514 µs, 468.254 µs] 70.308 µs (18.6%)
iast_TELEMETRY_OFF 481.395 µs [458.74 µs, 504.051 µs] 104.319 µs (27.7%)
tracing 444.42 µs [423.899 µs, 464.941 µs] 67.344 µs (17.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.661 µs [350.548 µs, 390.773 µs] -
iast 483.964 µs [462.264 µs, 505.664 µs] 113.303 µs (30.6%)
iast_FULL 560.991 µs [539.747 µs, 582.235 µs] 190.33 µs (51.3%)
iast_GLOBAL 505.556 µs [484.607 µs, 526.505 µs] 134.896 µs (36.4%)
iast_HARDCODED_SECRET_DISABLED 487.076 µs [464.704 µs, 509.448 µs] 116.415 µs (31.4%)
iast_INACTIVE 449.162 µs [428.04 µs, 470.285 µs] 78.502 µs (21.2%)
iast_TELEMETRY_OFF 472.809 µs [450.622 µs, 494.995 µs] 102.148 µs (27.6%)
tracing 444.85 µs [423.624 µs, 466.077 µs] 74.189 µs (20.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.322 ms) : 1303, 1341
.   : milestone, 1322,
appsec (1.72 ms) : 1695, 1744
.   : milestone, 1720,
appsec_no_iast (1.705 ms) : 1680, 1729
.   : milestone, 1705,
iast (1.469 ms) : 1446, 1491
.   : milestone, 1469,
profiling (1.469 ms) : 1445, 1493
.   : milestone, 1469,
tracing (1.475 ms) : 1452, 1498
.   : milestone, 1475,
section candidate
no_agent (1.342 ms) : 1322, 1361
.   : milestone, 1342,
appsec (1.738 ms) : 1714, 1762
.   : milestone, 1738,
appsec_no_iast (1.724 ms) : 1699, 1749
.   : milestone, 1724,
iast (1.489 ms) : 1467, 1511
.   : milestone, 1489,
profiling (1.486 ms) : 1461, 1510
.   : milestone, 1486,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.303 ms, 1.341 ms] -
appsec 1.72 ms [1.695 ms, 1.744 ms] 397.574 µs (30.1%)
appsec_no_iast 1.705 ms [1.68 ms, 1.729 ms] 382.685 µs (28.9%)
iast 1.469 ms [1.446 ms, 1.491 ms] 146.284 µs (11.1%)
profiling 1.469 ms [1.445 ms, 1.493 ms] 146.971 µs (11.1%)
tracing 1.475 ms [1.452 ms, 1.498 ms] 152.867 µs (11.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.322 ms, 1.361 ms] -
appsec 1.738 ms [1.714 ms, 1.762 ms] 396.022 µs (29.5%)
appsec_no_iast 1.724 ms [1.699 ms, 1.749 ms] 382.541 µs (28.5%)
iast 1.489 ms [1.467 ms, 1.511 ms] 147.226 µs (11.0%)
profiling 1.486 ms [1.461 ms, 1.51 ms] 143.822 µs (10.7%)
tracing 1.468 ms [1.444 ms, 1.492 ms] 126.192 µs (9.4%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/backport-7657
git_commit_date 1727095368 1727099721
git_commit_sha 27f522f c6196ff
release_version 1.40.0-SNAPSHOT~27f522f863 1.40.0-SNAPSHOT~c6196ffb81
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1727101562 1727101562
ci_job_id 648187079 648187079
ci_pipeline_id 44912078 44912078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.322 ms) : 2282, 2363
.   : milestone, 2322,
iast (2.049 ms) : 1999, 2099
.   : milestone, 2049,
iast_GLOBAL (2.103 ms) : 2051, 2154
.   : milestone, 2103,
profiling (1.933 ms) : 1893, 1973
.   : milestone, 1933,
tracing (1.899 ms) : 1861, 1937
.   : milestone, 1899,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.3 ms) : 2260, 2341
.   : milestone, 2300,
iast (2.024 ms) : 1976, 2071
.   : milestone, 2024,
iast_GLOBAL (2.096 ms) : 2046, 2146
.   : milestone, 2096,
profiling (1.933 ms) : 1892, 1974
.   : milestone, 1933,
tracing (1.897 ms) : 1859, 1935
.   : milestone, 1897,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.322 ms [2.282 ms, 2.363 ms] 856.078 µs (58.4%)
iast 2.049 ms [1.999 ms, 2.099 ms] 582.345 µs (39.7%)
iast_GLOBAL 2.103 ms [2.051 ms, 2.154 ms] 636.211 µs (43.4%)
profiling 1.933 ms [1.893 ms, 1.973 ms] 466.689 µs (31.8%)
tracing 1.899 ms [1.861 ms, 1.937 ms] 432.442 µs (29.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.454 ms, 1.477 ms] -
appsec 2.3 ms [2.26 ms, 2.341 ms] 835.236 µs (57.0%)
iast 2.024 ms [1.976 ms, 2.071 ms] 558.381 µs (38.1%)
iast_GLOBAL 2.096 ms [2.046 ms, 2.146 ms] 630.69 µs (43.0%)
profiling 1.933 ms [1.892 ms, 1.974 ms] 467.982 µs (31.9%)
tracing 1.897 ms [1.859 ms, 1.935 ms] 432.064 µs (29.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.40.0-SNAPSHOT~c6196ffb81, baseline=1.40.0-SNAPSHOT~27f522f863
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,
appsec (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
iast (18.894 s) : 18894000, 18894000
.   : milestone, 18894000,
iast_GLOBAL (18.082 s) : 18082000, 18082000
.   : milestone, 18082000,
profiling (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
tracing (15.16 s) : 15160000, 15160000
.   : milestone, 15160000,
section candidate
no_agent (15.785 s) : 15785000, 15785000
.   : milestone, 15785000,
appsec (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
iast (18.932 s) : 18932000, 18932000
.   : milestone, 18932000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
.   : milestone, 17882000,
profiling (15.7 s) : 15700000, 15700000
.   : milestone, 15700000,
tracing (14.996 s) : 14996000, 14996000
.   : milestone, 14996000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.046 s [15.046 s, 15.046 s] -
appsec 15.176 s [15.176 s, 15.176 s] 130.0 ms (0.9%)
iast 18.894 s [18.894 s, 18.894 s] 3.848 s (25.6%)
iast_GLOBAL 18.082 s [18.082 s, 18.082 s] 3.036 s (20.2%)
profiling 15.014 s [15.014 s, 15.014 s] -32.0 ms (-0.2%)
tracing 15.16 s [15.16 s, 15.16 s] 114.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.785 s [15.785 s, 15.785 s] -
appsec 15.022 s [15.022 s, 15.022 s] -763.0 ms (-4.8%)
iast 18.932 s [18.932 s, 18.932 s] 3.147 s (19.9%)
iast_GLOBAL 17.882 s [17.882 s, 17.882 s] 2.097 s (13.3%)
profiling 15.7 s [15.7 s, 15.7 s] -85.0 ms (-0.5%)
tracing 14.996 s [14.996 s, 14.996 s] -789.0 ms (-5.0%)

@smola smola merged commit b9e1c16 into release/v1.39.x Sep 23, 2024
94 of 98 checks passed
@smola smola deleted the smola/backport-7657 branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
1.39.1
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @PerfectSlayer @manuel-alvarez-alvarez