Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Kafka 3.8+ instrumentation by default #7908

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

nayeem-kamal
Copy link
Contributor

@nayeem-kamal nayeem-kamal commented Nov 7, 2024

This reverts commit 8c7495a.

What Does This Do

Disables kafka 3.8+ due to double instrumenting of classes which causes double the amount of traces for kafka. This is a breaking change and will be reverted once the double tracing issue is resolved.

Motivation

Kafka 3.8+ disabled by default to mitigate an ongoing bug

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@nayeem-kamal nayeem-kamal added the inst: kafka Kafka instrumentation label Nov 7, 2024
@nayeem-kamal nayeem-kamal requested a review from ygree November 7, 2024 16:53
@nayeem-kamal nayeem-kamal requested review from a team as code owners November 7, 2024 16:53
@nayeem-kamal nayeem-kamal enabled auto-merge (squash) November 7, 2024 16:56
@nayeem-kamal nayeem-kamal merged commit 39c11f9 into master Nov 7, 2024
96 of 103 checks passed
@nayeem-kamal nayeem-kamal deleted the nayeem-kamal/kafka-disabled-2 branch November 7, 2024 17:27
@github-actions github-actions bot added this to the 1.43.0 milestone Nov 7, 2024
@ygree ygree modified the milestones: 1.43.0, 1.42.1 Nov 7, 2024
@nayeem-kamal nayeem-kamal changed the title Revert "Removed config variable for disabling kafka-clients" Disable Kafka 3.8+ instrumentation by default Nov 8, 2024
@nayeem-kamal nayeem-kamal added the tag: breaking change Breaking changes label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

3 similar comments
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

jandro996 pushed a commit that referenced this pull request Nov 11, 2024
@mcculls mcculls added tag: no release notes Changes to exclude from release notes and removed tag: breaking change Breaking changes labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inst: kafka Kafka instrumentation tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants