Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot #8058

mcculls · 2024-12-05T11:50:15Z

Motivation

Notification that support for custom OpenTracing ScopeManagers in dd-trace-ot will soon be removed (expected v1.45.0) as part of a refactoring to improve support for generic Contexts across the dd-trace-java codebase.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-953

…elease of dd-trace-ot

amarziali

👍

pr-commenter · 2024-12-05T12:20:36Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/deprecate-custom-scopemanagers
git_commit_date	1733317832	1733398795
git_commit_sha	`5b58772`	`a5eccec`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~a5eccec3a8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733401189	1733401189
ci_job_id	727928650	727928650
ci_pipeline_id	50387669	50387669
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096075
Total [baseline] (10.46 s) : 0, 10460355
Agent [candidate] (1.097 s) : 0, 1097232
Total [candidate] (10.417 s) : 0, 10416648
section appsec
Agent [baseline] (1.231 s) : 0, 1230990
Total [baseline] (10.739 s) : 0, 10738572
Agent [candidate] (1.232 s) : 0, 1232323
Total [candidate] (10.724 s) : 0, 10724386
section iast
Agent [baseline] (1.239 s) : 0, 1238511
Total [baseline] (10.945 s) : 0, 10944965
Agent [candidate] (1.221 s) : 0, 1221336
Total [candidate] (10.978 s) : 0, 10978056
section profiling
Agent [baseline] (1.324 s) : 0, 1324125
Total [baseline] (10.851 s) : 0, 10850993
Agent [candidate] (1.319 s) : 0, 1318845
Total [candidate] (10.862 s) : 0, 10862363

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	appsec	1.231 s	134.916 ms (12.3%)
Agent	iast	1.239 s	142.437 ms (13.0%)
Agent	profiling	1.324 s	228.051 ms (20.8%)
Total	tracing	10.46 s	-
Total	appsec	10.739 s	278.217 ms (2.7%)
Total	iast	10.945 s	484.61 ms (4.6%)
Total	profiling	10.851 s	390.638 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.097 s	-
Agent	appsec	1.232 s	135.091 ms (12.3%)
Agent	iast	1.221 s	124.104 ms (11.3%)
Agent	profiling	1.319 s	221.613 ms (20.2%)
Total	tracing	10.417 s	-
Total	appsec	10.724 s	307.738 ms (3.0%)
Total	iast	10.978 s	561.408 ms (5.4%)
Total	profiling	10.862 s	445.715 ms (4.3%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.823 ms) : 0, 696823
BytebuddyAgent [candidate] (700.703 ms) : 0, 700703
GlobalTracer [baseline] (318.832 ms) : 0, 318832
GlobalTracer [candidate] (318.839 ms) : 0, 318839
AppSec [baseline] (54.587 ms) : 0, 54587
AppSec [candidate] (54.66 ms) : 0, 54660
Remote Config [baseline] (677.182 µs) : 0, 677
Remote Config [candidate] (679.528 µs) : 0, 680
Telemetry [baseline] (11.416 ms) : 0, 11416
Telemetry [candidate] (8.425 ms) : 0, 8425
section appsec
BytebuddyAgent [baseline] (715.596 ms) : 0, 715596
BytebuddyAgent [candidate] (715.745 ms) : 0, 715745
GlobalTracer [baseline] (315.745 ms) : 0, 315745
GlobalTracer [candidate] (316.694 ms) : 0, 316694
AppSec [baseline] (167.3 ms) : 0, 167300
AppSec [candidate] (167.548 ms) : 0, 167548
Remote Config [baseline] (671.321 µs) : 0, 671
Remote Config [candidate] (669.586 µs) : 0, 670
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.171 ms) : 0, 8171
IAST [baseline] (19.224 ms) : 0, 19224
IAST [candidate] (19.309 ms) : 0, 19309
section iast
BytebuddyAgent [baseline] (826.355 ms) : 0, 826355
BytebuddyAgent [candidate] (813.042 ms) : 0, 813042
GlobalTracer [baseline] (310.172 ms) : 0, 310172
GlobalTracer [candidate] (306.79 ms) : 0, 306790
AppSec [baseline] (57.683 ms) : 0, 57683
AppSec [candidate] (57.506 ms) : 0, 57506
Remote Config [baseline] (633.465 µs) : 0, 633
Remote Config [candidate] (637.964 µs) : 0, 638
Telemetry [baseline] (7.669 ms) : 0, 7669
Telemetry [candidate] (7.616 ms) : 0, 7616
IAST [baseline] (22.041 ms) : 0, 22041
IAST [candidate] (21.954 ms) : 0, 21954
section profiling
BytebuddyAgent [baseline] (693.202 ms) : 0, 693202
BytebuddyAgent [candidate] (690.068 ms) : 0, 690068
GlobalTracer [baseline] (434.98 ms) : 0, 434980
GlobalTracer [candidate] (434.138 ms) : 0, 434138
AppSec [baseline] (53.79 ms) : 0, 53790
AppSec [candidate] (53.593 ms) : 0, 53593
Remote Config [baseline] (663.685 µs) : 0, 664
Remote Config [candidate] (650.125 µs) : 0, 650
Telemetry [baseline] (7.793 ms) : 0, 7793
Telemetry [candidate] (7.712 ms) : 0, 7712
ProfilingAgent [baseline] (94.334 ms) : 0, 94334
ProfilingAgent [candidate] (93.384 ms) : 0, 93384
Profiling [baseline] (94.357 ms) : 0, 94357
Profiling [candidate] (93.407 ms) : 0, 93407

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095094
Total [baseline] (8.659 s) : 0, 8658569
Agent [candidate] (1.091 s) : 0, 1091248
Total [candidate] (8.647 s) : 0, 8646867
section iast
Agent [baseline] (1.223 s) : 0, 1222815
Total [baseline] (9.223 s) : 0, 9223351
Agent [candidate] (1.226 s) : 0, 1226389
Total [candidate] (9.229 s) : 0, 9228551
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1220191
Total [baseline] (9.162 s) : 0, 9161529
Agent [candidate] (1.223 s) : 0, 1222692
Total [candidate] (9.185 s) : 0, 9184923
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1218311
Total [baseline] (9.307 s) : 0, 9306684
Agent [candidate] (1.218 s) : 0, 1217739
Total [candidate] (9.193 s) : 0, 9192577

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	iast	1.223 s	127.722 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	125.098 ms (11.4%)
Agent	iast_TELEMETRY_OFF	1.218 s	123.217 ms (11.3%)
Total	tracing	8.659 s	-
Total	iast	9.223 s	564.782 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.162 s	502.96 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.307 s	648.115 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	iast	1.226 s	135.141 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.223 s	131.443 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.218 s	126.491 ms (11.6%)
Total	tracing	8.647 s	-
Total	iast	9.229 s	581.683 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.185 s	538.056 ms (6.2%)
Total	iast_TELEMETRY_OFF	9.193 s	545.71 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.456 ms) : 0, 696456
BytebuddyAgent [candidate] (695.475 ms) : 0, 695475
GlobalTracer [baseline] (317.97 ms) : 0, 317970
GlobalTracer [candidate] (317.788 ms) : 0, 317788
AppSec [baseline] (54.826 ms) : 0, 54826
AppSec [candidate] (54.406 ms) : 0, 54406
Remote Config [baseline] (676.871 µs) : 0, 677
Remote Config [candidate] (670.694 µs) : 0, 671
Telemetry [baseline] (11.374 ms) : 0, 11374
Telemetry [candidate] (9.132 ms) : 0, 9132
section iast
BytebuddyAgent [baseline] (814.63 ms) : 0, 814630
BytebuddyAgent [candidate] (818.57 ms) : 0, 818570
GlobalTracer [baseline] (306.927 ms) : 0, 306927
GlobalTracer [candidate] (307.098 ms) : 0, 307098
AppSec [baseline] (57.993 ms) : 0, 57993
AppSec [candidate] (57.841 ms) : 0, 57841
IAST [baseline] (21.142 ms) : 0, 21142
IAST [candidate] (20.808 ms) : 0, 20808
Remote Config [baseline] (652.348 µs) : 0, 652
Remote Config [candidate] (621.703 µs) : 0, 622
Telemetry [baseline] (7.623 ms) : 0, 7623
Telemetry [candidate] (7.509 ms) : 0, 7509
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.935 ms) : 0, 812935
BytebuddyAgent [candidate] (814.616 ms) : 0, 814616
GlobalTracer [baseline] (306.966 ms) : 0, 306966
GlobalTracer [candidate] (307.07 ms) : 0, 307070
AppSec [baseline] (57.621 ms) : 0, 57621
AppSec [candidate] (58.01 ms) : 0, 58010
IAST [baseline] (20.782 ms) : 0, 20782
IAST [candidate] (20.982 ms) : 0, 20982
Remote Config [baseline] (625.308 µs) : 0, 625
Remote Config [candidate] (637.833 µs) : 0, 638
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.536 ms) : 0, 7536
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.251 ms) : 0, 811251
BytebuddyAgent [candidate] (810.526 ms) : 0, 810526
GlobalTracer [baseline] (306.439 ms) : 0, 306439
GlobalTracer [candidate] (306.952 ms) : 0, 306952
AppSec [baseline] (57.608 ms) : 0, 57608
AppSec [candidate] (56.443 ms) : 0, 56443
IAST [baseline] (21.229 ms) : 0, 21229
IAST [candidate] (21.987 ms) : 0, 21987
Remote Config [baseline] (616.563 µs) : 0, 617
Remote Config [candidate] (620.143 µs) : 0, 620
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.356 ms) : 0, 7356

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-05T11:49:53	2024-12-05T11:56:52
git_branch	master	mcculls/deprecate-custom-scopemanagers
git_commit_date	1733317832	1733398795
git_commit_sha	`5b58772`	`a5eccec`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~a5eccec3a8
start_time	2024-12-05T11:49:39	2024-12-05T11:56:39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733400164	1733400164
ci_job_id	727928651	727928651
ci_pipeline_id	50387669	50387669
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.381 ms) : 1362, 1401
.   : milestone, 1381,
appsec (1.766 ms) : 1742, 1790
.   : milestone, 1766,
appsec_no_iast (1.744 ms) : 1719, 1769
.   : milestone, 1744,
iast (1.506 ms) : 1483, 1528
.   : milestone, 1506,
profiling (1.548 ms) : 1524, 1572
.   : milestone, 1548,
tracing (1.482 ms) : 1458, 1506
.   : milestone, 1482,
section candidate
no_agent (1.352 ms) : 1333, 1372
.   : milestone, 1352,
appsec (1.744 ms) : 1722, 1767
.   : milestone, 1744,
appsec_no_iast (1.756 ms) : 1732, 1780
.   : milestone, 1756,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.516 ms) : 1493, 1540
.   : milestone, 1516,
tracing (1.48 ms) : 1454, 1505
.   : milestone, 1480,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.381 ms [1.362 ms, 1.401 ms]	-
appsec	1.766 ms [1.742 ms, 1.79 ms]	385.093 µs (27.9%)
appsec_no_iast	1.744 ms [1.719 ms, 1.769 ms]	362.875 µs (26.3%)
iast	1.506 ms [1.483 ms, 1.528 ms]	124.389 µs (9.0%)
profiling	1.548 ms [1.524 ms, 1.572 ms]	166.735 µs (12.1%)
tracing	1.482 ms [1.458 ms, 1.506 ms]	100.525 µs (7.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.333 ms, 1.372 ms]	-
appsec	1.744 ms [1.722 ms, 1.767 ms]	392.032 µs (29.0%)
appsec_no_iast	1.756 ms [1.732 ms, 1.78 ms]	403.754 µs (29.9%)
iast	1.502 ms [1.479 ms, 1.525 ms]	149.688 µs (11.1%)
profiling	1.516 ms [1.493 ms, 1.54 ms]	164.175 µs (12.1%)
tracing	1.48 ms [1.454 ms, 1.505 ms]	127.345 µs (9.4%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.305 µs) : 349, 388
.   : milestone, 368,
iast (490.905 µs) : 469, 513
.   : milestone, 491,
iast_FULL (643.474 µs) : 622, 665
.   : milestone, 643,
iast_GLOBAL (510.0 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (490.479 µs) : 469, 512
.   : milestone, 490,
iast_INACTIVE (453.059 µs) : 431, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (473.798 µs) : 453, 495
.   : milestone, 474,
tracing (444.741 µs) : 424, 466
.   : milestone, 445,
section candidate
no_agent (372.317 µs) : 353, 392
.   : milestone, 372,
iast (490.957 µs) : 469, 513
.   : milestone, 491,
iast_FULL (646.445 µs) : 625, 668
.   : milestone, 646,
iast_GLOBAL (511.145 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (485.593 µs) : 464, 507
.   : milestone, 486,
iast_INACTIVE (453.057 µs) : 431, 475
.   : milestone, 453,
iast_TELEMETRY_OFF (480.817 µs) : 459, 502
.   : milestone, 481,
tracing (445.948 µs) : 425, 467
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.305 µs [348.66 µs, 387.95 µs]	-
iast	490.905 µs [468.735 µs, 513.076 µs]	122.6 µs (33.3%)
iast_FULL	643.474 µs [622.118 µs, 664.831 µs]	275.169 µs (74.7%)
iast_GLOBAL	510.0 µs [488.783 µs, 531.217 µs]	141.695 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED	490.479 µs [469.217 µs, 511.74 µs]	122.173 µs (33.2%)
iast_INACTIVE	453.059 µs [431.447 µs, 474.67 µs]	84.753 µs (23.0%)
iast_TELEMETRY_OFF	473.798 µs [452.636 µs, 494.959 µs]	105.492 µs (28.6%)
tracing	444.741 µs [423.742 µs, 465.741 µs]	76.436 µs (20.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.317 µs [352.648 µs, 391.986 µs]	-
iast	490.957 µs [469.301 µs, 512.613 µs]	118.64 µs (31.9%)
iast_FULL	646.445 µs [625.071 µs, 667.818 µs]	274.128 µs (73.6%)
iast_GLOBAL	511.145 µs [489.393 µs, 532.896 µs]	138.827 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED	485.593 µs [464.157 µs, 507.03 µs]	113.276 µs (30.4%)
iast_INACTIVE	453.057 µs [431.155 µs, 474.959 µs]	80.74 µs (21.7%)
iast_TELEMETRY_OFF	480.817 µs [459.141 µs, 502.492 µs]	108.499 µs (29.1%)
tracing	445.948 µs [424.869 µs, 467.028 µs]	73.631 µs (19.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/deprecate-custom-scopemanagers
git_commit_date	1733317832	1733398795
git_commit_sha	`5b58772`	`a5eccec`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~a5eccec3a8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733400883	1733400883
ci_job_id	727928652	727928652
ci_pipeline_id	50387669	50387669
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
appsec (14.858 s) : 14858000, 14858000
.   : milestone, 14858000,
iast (18.725 s) : 18725000, 18725000
.   : milestone, 18725000,
iast_GLOBAL (17.821 s) : 17821000, 17821000
.   : milestone, 17821000,
profiling (15.135 s) : 15135000, 15135000
.   : milestone, 15135000,
tracing (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
.   : milestone, 14975000,
appsec (14.965 s) : 14965000, 14965000
.   : milestone, 14965000,
iast (18.696 s) : 18696000, 18696000
.   : milestone, 18696000,
iast_GLOBAL (18.013 s) : 18013000, 18013000
.   : milestone, 18013000,
profiling (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
tracing (15.142 s) : 15142000, 15142000
.   : milestone, 15142000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.017 s [15.017 s, 15.017 s]	-
appsec	14.858 s [14.858 s, 14.858 s]	-159.0 ms (-1.1%)
iast	18.725 s [18.725 s, 18.725 s]	3.708 s (24.7%)
iast_GLOBAL	17.821 s [17.821 s, 17.821 s]	2.804 s (18.7%)
profiling	15.135 s [15.135 s, 15.135 s]	118.0 ms (0.8%)
tracing	14.995 s [14.995 s, 14.995 s]	-22.0 ms (-0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.975 s [14.975 s, 14.975 s]	-
appsec	14.965 s [14.965 s, 14.965 s]	-10.0 ms (-0.1%)
iast	18.696 s [18.696 s, 18.696 s]	3.721 s (24.8%)
iast_GLOBAL	18.013 s [18.013 s, 18.013 s]	3.038 s (20.3%)
profiling	15.005 s [15.005 s, 15.005 s]	30.0 ms (0.2%)
tracing	15.142 s [15.142 s, 15.142 s]	167.0 ms (1.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~a5eccec3a8, baseline=1.44.0-SNAPSHOT~5b587720dd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.329 ms) : 2288, 2370
.   : milestone, 2329,
iast (2.074 ms) : 2021, 2126
.   : milestone, 2074,
iast_GLOBAL (2.13 ms) : 2077, 2183
.   : milestone, 2130,
profiling (1.941 ms) : 1899, 1983
.   : milestone, 1941,
tracing (1.914 ms) : 1874, 1954
.   : milestone, 1914,
section candidate
no_agent (1.466 ms) : 1455, 1477
.   : milestone, 1466,
appsec (2.331 ms) : 2289, 2372
.   : milestone, 2331,
iast (2.077 ms) : 2025, 2129
.   : milestone, 2077,
iast_GLOBAL (2.118 ms) : 2065, 2170
.   : milestone, 2118,
profiling (1.962 ms) : 1918, 2005
.   : milestone, 1962,
tracing (1.918 ms) : 1878, 1959
.   : milestone, 1918,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.477 ms]	-
appsec	2.329 ms [2.288 ms, 2.37 ms]	863.837 µs (59.0%)
iast	2.074 ms [2.021 ms, 2.126 ms]	608.752 µs (41.6%)
iast_GLOBAL	2.13 ms [2.077 ms, 2.183 ms]	664.884 µs (45.4%)
profiling	1.941 ms [1.899 ms, 1.983 ms]	475.783 µs (32.5%)
tracing	1.914 ms [1.874 ms, 1.954 ms]	448.71 µs (30.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.455 ms, 1.477 ms]	-
appsec	2.331 ms [2.289 ms, 2.372 ms]	864.793 µs (59.0%)
iast	2.077 ms [2.025 ms, 2.129 ms]	611.034 µs (41.7%)
iast_GLOBAL	2.118 ms [2.065 ms, 2.17 ms]	651.896 µs (44.5%)
profiling	1.962 ms [1.918 ms, 2.005 ms]	495.603 µs (33.8%)
tracing	1.918 ms [1.878 ms, 1.959 ms]	452.547 µs (30.9%)

PerfectSlayer

🍾

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#8089](DataDog/dd-trace-java#8089) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#8044](DataDog/dd-trace-java#8044) - [@smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#8038](DataDog/dd-trace-java#8038) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#8026](DataDog/dd-trace-java#8026) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#8013](DataDog/dd-trace-java#8013) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#8010](DataDog/dd-trace-java#8010) - [@Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#8004](DataDog/dd-trace-java#8004) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#8078](DataDog/dd-trace-java#8078) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#8055](DataDog/dd-trace-java#8055) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#8033](DataDog/dd-trace-java#8033) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#8030](DataDog/dd-trace-java#8030) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#8045](DataDog/dd-trace-java#8045) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#8071](DataDog/dd-trace-java#8071) - [@piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#8051](DataDog/dd-trace-java#8051) - [@kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#8039](DataDog/dd-trace-java#8039) - [@jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#8021](DataDog/dd-trace-java#8021) - [@jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#8016](DataDog/dd-trace-java#8016) - [@evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#7942](DataDog/dd-trace-java#7942) - [@evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#8065](DataDog/dd-trace-java#8065) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#8036](DataDog/dd-trace-java#8036) - [@mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#8058](DataDog/dd-trace-java#8058) - [@mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#8064](DataDog/dd-trace-java#8064) - [@amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#8061](DataDog/dd-trace-java#8061) - [@amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#8040](DataDog/dd-trace-java#8040) - [@cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#8028](DataDog/dd-trace-java#8028) - [@mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#7973](DataDog/dd-trace-java#7973) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#7946](DataDog/dd-trace-java#7946) - [@smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#7920](DataDog/dd-trace-java#7920) - [@Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#8043](DataDog/dd-trace-java#8043) - [@amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#7940](DataDog/dd-trace-java#7940) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#8062](DataDog/dd-trace-java#8062) - [@amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#7959](DataDog/dd-trace-java#7959) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#8019](DataDog/dd-trace-java#8019) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#8012](DataDog/dd-trace-java#8012) - [@mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#8005](DataDog/dd-trace-java#8005) - [@amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#8025](DataDog/dd-trace-java#8025) - [@amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#7981](DataDog/dd-trace-java#7981) - [@amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c

Custom ScopeManagers are deprecated and will be removed in a future r…

a5eccec

…elease of dd-trace-ot

mcculls added type: refactoring comp: opentracing OpenTracing labels Dec 5, 2024

mcculls marked this pull request as ready for review December 5, 2024 11:50

mcculls requested a review from a team as a code owner December 5, 2024 11:50

mcculls requested a review from manuel-alvarez-alvarez December 5, 2024 11:50

amarziali approved these changes Dec 5, 2024

View reviewed changes

PerfectSlayer approved these changes Dec 5, 2024

View reviewed changes

mcculls merged commit 6d420cc into master Dec 5, 2024
156 checks passed

mcculls deleted the mcculls/deprecate-custom-scopemanagers branch December 5, 2024 13:57

github-actions bot added this to the 1.44.0 milestone Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot #8058

Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot #8058

mcculls commented Dec 5, 2024 •

edited by jira bot

Loading

amarziali left a comment

pr-commenter bot commented Dec 5, 2024

PerfectSlayer left a comment

Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot #8058

Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot #8058

Conversation

mcculls commented Dec 5, 2024 • edited by jira bot Loading

Motivation

Contributor Checklist

amarziali left a comment

Choose a reason for hiding this comment

pr-commenter bot commented Dec 5, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

PerfectSlayer left a comment

Choose a reason for hiding this comment

mcculls commented Dec 5, 2024 •

edited by jira bot

Loading