Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves ServiceNameCollector #8109

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Improves ServiceNameCollector #8109

merged 3 commits into from
Dec 20, 2024

Conversation

amarziali
Copy link
Collaborator

What Does This Do

ServiceNameCollector.add is called very frequently. This PR aims moving the expensive operations inside it (i.e. string case transformation, default service name deduplication) to the getServices method that's called way more infrequently

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner December 18, 2024 11:21
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali mentioned this pull request Dec 18, 2024
Merged
@amarziali @mcculls
Update internal-api/src/main/java/datadog/trace/api/remoteconfig/Serv…
ab684c1 
…iceNameCollector.java

Co-authored-by: Stuart McCulloch <[email protected]>
mcculls
mcculls reviewed Dec 18, 2024
View reviewed changes
internal-api/src/main/java/datadog/trace/api/remoteconfig/ServiceNameCollector.java Outdated
if (services.isEmpty()) {
return null;
}
final Set<String> uniques = new HashSet<>(services.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also use TreeSet<String>(String.CASE_INSENSITIVE_ORDER); to avoid the need for any lower-casing

You'd then use Config.get().getServiceName().equalsIgnoreCase(...) below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe even

Set<String> uniqueNames = new TreeSet<String>(String.CASE_INSENSITIVE_ORDER);
uniqueNames.addAll(services.keySet());
uniqueNames.remove(Config.get().getServiceName());
return new ArrayList<>(uniqueNames);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes completely sense. It's way better. 🤦 I just changed it

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/improve-servicenamecollector
git_commit_date 1734517793 1734540744
git_commit_sha a19f73a da89e60
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~da89e60163
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734543195 1734543195
ci_job_id 744262688 744262688
ci_pipeline_id 51472866 51472866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099959
Total [baseline] (8.684 s) : 0, 8683570
Agent [candidate] (1.095 s) : 0, 1095380
Total [candidate] (8.64 s) : 0, 8640262
section iast
Agent [baseline] (1.22 s) : 0, 1220392
Total [baseline] (9.189 s) : 0, 9188512
Agent [candidate] (1.23 s) : 0, 1230087
Total [candidate] (9.183 s) : 0, 9182749
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.229 s) : 0, 1228976
Total [baseline] (9.2 s) : 0, 9200084
Agent [candidate] (1.222 s) : 0, 1221974
Total [candidate] (9.167 s) : 0, 9167474
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1217668
Total [baseline] (9.165 s) : 0, 9165308
Agent [candidate] (1.218 s) : 0, 1217570
Total [candidate] (9.163 s) : 0, 9163278
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent iast 1.22 s 120.433 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.229 s 129.017 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.218 s 117.708 ms (10.7%)
Total tracing 8.684 s -
Total iast 9.189 s 504.942 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.2 s 516.514 ms (5.9%)
Total iast_TELEMETRY_OFF 9.165 s 481.739 ms (5.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.095 s -
Agent iast 1.23 s 134.707 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.222 s 126.593 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.218 s 122.19 ms (11.2%)
Total tracing 8.64 s -
Total iast 9.183 s 542.488 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.167 s 527.212 ms (6.1%)
Total iast_TELEMETRY_OFF 9.163 s 523.016 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.666 ms) : 0, 701666
BytebuddyAgent [candidate] (696.793 ms) : 0, 696793
GlobalTracer [baseline] (317.085 ms) : 0, 317085
GlobalTracer [candidate] (318.831 ms) : 0, 318831
AppSec [baseline] (54.674 ms) : 0, 54674
AppSec [candidate] (55.177 ms) : 0, 55177
Remote Config [baseline] (656.339 µs) : 0, 656
Remote Config [candidate] (715.281 µs) : 0, 715
Telemetry [baseline] (12.06 ms) : 0, 12060
Telemetry [candidate] (10.083 ms) : 0, 10083
section iast
BytebuddyAgent [baseline] (813.116 ms) : 0, 813116
BytebuddyAgent [candidate] (820.571 ms) : 0, 820571
GlobalTracer [baseline] (305.629 ms) : 0, 305629
GlobalTracer [candidate] (308.059 ms) : 0, 308059
AppSec [baseline] (55.297 ms) : 0, 55297
AppSec [candidate] (57.627 ms) : 0, 57627
IAST [baseline] (24.51 ms) : 0, 24510
IAST [candidate] (21.829 ms) : 0, 21829
Remote Config [baseline] (609.964 µs) : 0, 610
Remote Config [candidate] (618.293 µs) : 0, 618
Telemetry [baseline] (7.485 ms) : 0, 7485
Telemetry [candidate] (7.535 ms) : 0, 7535
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (819.185 ms) : 0, 819185
BytebuddyAgent [candidate] (814.384 ms) : 0, 814384
GlobalTracer [baseline] (307.419 ms) : 0, 307419
GlobalTracer [candidate] (306.159 ms) : 0, 306159
AppSec [baseline] (57.958 ms) : 0, 57958
AppSec [candidate] (57.621 ms) : 0, 57621
IAST [baseline] (22.384 ms) : 0, 22384
IAST [candidate] (21.903 ms) : 0, 21903
Remote Config [baseline] (628.725 µs) : 0, 629
Remote Config [candidate] (622.268 µs) : 0, 622
Telemetry [baseline] (7.605 ms) : 0, 7605
Telemetry [candidate] (7.514 ms) : 0, 7514
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.433 ms) : 0, 811433
BytebuddyAgent [candidate] (811.157 ms) : 0, 811157
GlobalTracer [baseline] (305.965 ms) : 0, 305965
GlobalTracer [candidate] (305.933 ms) : 0, 305933
AppSec [baseline] (58.026 ms) : 0, 58026
AppSec [candidate] (58.179 ms) : 0, 58179
IAST [baseline] (20.473 ms) : 0, 20473
IAST [candidate] (20.561 ms) : 0, 20561
Remote Config [baseline] (636.562 µs) : 0, 637
Remote Config [candidate] (606.826 µs) : 0, 607
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.341 ms) : 0, 7341
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092435
Total [baseline] (10.457 s) : 0, 10457480
Agent [candidate] (1.092 s) : 0, 1092468
Total [candidate] (10.477 s) : 0, 10477160
section appsec
Agent [baseline] (1.228 s) : 0, 1228429
Total [baseline] (10.71 s) : 0, 10710493
Agent [candidate] (1.229 s) : 0, 1228775
Total [candidate] (10.674 s) : 0, 10674239
section iast
Agent [baseline] (1.222 s) : 0, 1222479
Total [baseline] (11.012 s) : 0, 11011965
Agent [candidate] (1.232 s) : 0, 1231628
Total [candidate] (10.961 s) : 0, 10961489
section profiling
Agent [baseline] (1.319 s) : 0, 1319027
Total [baseline] (10.856 s) : 0, 10855698
Agent [candidate] (1.315 s) : 0, 1314821
Total [candidate] (10.81 s) : 0, 10810408
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.228 s 135.993 ms (12.4%)
Agent iast 1.222 s 130.044 ms (11.9%)
Agent profiling 1.319 s 226.591 ms (20.7%)
Total tracing 10.457 s -
Total appsec 10.71 s 253.013 ms (2.4%)
Total iast 11.012 s 554.485 ms (5.3%)
Total profiling 10.856 s 398.217 ms (3.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent appsec 1.229 s 136.307 ms (12.5%)
Agent iast 1.232 s 139.16 ms (12.7%)
Agent profiling 1.315 s 222.353 ms (20.4%)
Total tracing 10.477 s -
Total appsec 10.674 s 197.078 ms (1.9%)
Total iast 10.961 s 484.329 ms (4.6%)
Total profiling 10.81 s 333.247 ms (3.2%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.339 ms) : 0, 696339
BytebuddyAgent [candidate] (696.891 ms) : 0, 696891
GlobalTracer [baseline] (317.119 ms) : 0, 317119
GlobalTracer [candidate] (317.189 ms) : 0, 317189
AppSec [baseline] (54.542 ms) : 0, 54542
AppSec [candidate] (54.662 ms) : 0, 54662
Remote Config [baseline] (663.993 µs) : 0, 664
Remote Config [candidate] (676.545 µs) : 0, 677
Telemetry [baseline] (10.019 ms) : 0, 10019
Telemetry [candidate] (9.284 ms) : 0, 9284
section appsec
BytebuddyAgent [baseline] (714.955 ms) : 0, 714955
BytebuddyAgent [candidate] (713.539 ms) : 0, 713539
GlobalTracer [baseline] (314.157 ms) : 0, 314157
GlobalTracer [candidate] (315.438 ms) : 0, 315438
AppSec [baseline] (166.099 ms) : 0, 166099
AppSec [candidate] (166.93 ms) : 0, 166930
Remote Config [baseline] (659.795 µs) : 0, 660
Remote Config [candidate] (659.578 µs) : 0, 660
Telemetry [baseline] (8.91 ms) : 0, 8910
Telemetry [candidate] (8.489 ms) : 0, 8489
IAST [baseline] (19.721 ms) : 0, 19721
IAST [candidate] (19.927 ms) : 0, 19927
section iast
BytebuddyAgent [baseline] (814.217 ms) : 0, 814217
BytebuddyAgent [candidate] (821.608 ms) : 0, 821608
GlobalTracer [baseline] (306.245 ms) : 0, 306245
GlobalTracer [candidate] (308.49 ms) : 0, 308490
AppSec [baseline] (57.006 ms) : 0, 57006
AppSec [candidate] (57.396 ms) : 0, 57396
Remote Config [baseline] (625.776 µs) : 0, 626
Remote Config [candidate] (624.23 µs) : 0, 624
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.546 ms) : 0, 7546
IAST [baseline] (23.046 ms) : 0, 23046
IAST [candidate] (22.045 ms) : 0, 22045
section profiling
BytebuddyAgent [baseline] (690.826 ms) : 0, 690826
BytebuddyAgent [candidate] (688.988 ms) : 0, 688988
GlobalTracer [baseline] (433.925 ms) : 0, 433925
GlobalTracer [candidate] (431.623 ms) : 0, 431623
AppSec [baseline] (53.436 ms) : 0, 53436
AppSec [candidate] (53.337 ms) : 0, 53337
Remote Config [baseline] (680.901 µs) : 0, 681
Remote Config [candidate] (659.083 µs) : 0, 659
Telemetry [baseline] (8.039 ms) : 0, 8039
Telemetry [candidate] (7.738 ms) : 0, 7738
ProfilingAgent [baseline] (92.884 ms) : 0, 92884
ProfilingAgent [candidate] (93.248 ms) : 0, 93248
Profiling [baseline] (92.907 ms) : 0, 92907
Profiling [candidate] (93.273 ms) : 0, 93273
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-18T17:03:20 2024-12-18T17:10:17
git_branch master andrea.marziali/improve-servicenamecollector
git_commit_date 1734517793 1734540744
git_commit_sha a19f73a da89e60
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~da89e60163
start_time 2024-12-18T17:03:06 2024-12-18T17:10:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734542168 1734542168
ci_job_id 744262690 744262690
ci_pipeline_id 51472866 51472866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1326, 1367
.   : milestone, 1347,
appsec (1.759 ms) : 1734, 1784
.   : milestone, 1759,
appsec_no_iast (1.757 ms) : 1733, 1781
.   : milestone, 1757,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.503 ms) : 1479, 1526
.   : milestone, 1503,
tracing (1.462 ms) : 1437, 1487
.   : milestone, 1462,
section candidate
no_agent (1.351 ms) : 1331, 1371
.   : milestone, 1351,
appsec (1.744 ms) : 1720, 1767
.   : milestone, 1744,
appsec_no_iast (1.727 ms) : 1703, 1752
.   : milestone, 1727,
iast (1.531 ms) : 1508, 1553
.   : milestone, 1531,
profiling (1.49 ms) : 1466, 1513
.   : milestone, 1490,
tracing (1.479 ms) : 1455, 1503
.   : milestone, 1479,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.326 ms, 1.367 ms] -
appsec 1.759 ms [1.734 ms, 1.784 ms] 412.3 µs (30.6%)
appsec_no_iast 1.757 ms [1.733 ms, 1.781 ms] 410.393 µs (30.5%)
iast 1.488 ms [1.465 ms, 1.511 ms] 141.111 µs (10.5%)
profiling 1.503 ms [1.479 ms, 1.526 ms] 156.142 µs (11.6%)
tracing 1.462 ms [1.437 ms, 1.487 ms] 114.952 µs (8.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.331 ms, 1.371 ms] -
appsec 1.744 ms [1.72 ms, 1.767 ms] 392.309 µs (29.0%)
appsec_no_iast 1.727 ms [1.703 ms, 1.752 ms] 376.178 µs (27.8%)
iast 1.531 ms [1.508 ms, 1.553 ms] 179.371 µs (13.3%)
profiling 1.49 ms [1.466 ms, 1.513 ms] 138.472 µs (10.2%)
tracing 1.479 ms [1.455 ms, 1.503 ms] 127.868 µs (9.5%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.23 µs) : 350, 392
.   : milestone, 371,
iast (487.514 µs) : 466, 509
.   : milestone, 488,
iast_FULL (654.326 µs) : 633, 676
.   : milestone, 654,
iast_GLOBAL (513.695 µs) : 492, 536
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (491.082 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (446.517 µs) : 425, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (482.757 µs) : 461, 504
.   : milestone, 483,
tracing (448.646 µs) : 427, 470
.   : milestone, 449,
section candidate
no_agent (372.966 µs) : 353, 393
.   : milestone, 373,
iast (488.472 µs) : 467, 510
.   : milestone, 488,
iast_FULL (649.133 µs) : 628, 671
.   : milestone, 649,
iast_GLOBAL (522.313 µs) : 499, 545
.   : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (485.267 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (451.709 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (478.516 µs) : 457, 500
.   : milestone, 479,
tracing (446.936 µs) : 426, 468
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.23 µs [350.482 µs, 391.979 µs] -
iast 487.514 µs [465.965 µs, 509.063 µs] 116.284 µs (31.3%)
iast_FULL 654.326 µs [632.842 µs, 675.809 µs] 283.096 µs (76.3%)
iast_GLOBAL 513.695 µs [491.796 µs, 535.594 µs] 142.465 µs (38.4%)
iast_HARDCODED_SECRET_DISABLED 491.082 µs [469.553 µs, 512.61 µs] 119.851 µs (32.3%)
iast_INACTIVE 446.517 µs [425.429 µs, 467.606 µs] 75.287 µs (20.3%)
iast_TELEMETRY_OFF 482.757 µs [461.03 µs, 504.485 µs] 111.527 µs (30.0%)
tracing 448.646 µs [427.057 µs, 470.236 µs] 77.416 µs (20.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.966 µs [353.123 µs, 392.809 µs] -
iast 488.472 µs [466.557 µs, 510.386 µs] 115.505 µs (31.0%)
iast_FULL 649.133 µs [627.686 µs, 670.581 µs] 276.167 µs (74.0%)
iast_GLOBAL 522.313 µs [499.329 µs, 545.298 µs] 149.347 µs (40.0%)
iast_HARDCODED_SECRET_DISABLED 485.267 µs [463.815 µs, 506.719 µs] 112.301 µs (30.1%)
iast_INACTIVE 451.709 µs [430.505 µs, 472.912 µs] 78.743 µs (21.1%)
iast_TELEMETRY_OFF 478.516 µs [456.945 µs, 500.086 µs] 105.55 µs (28.3%)
tracing 446.936 µs [425.569 µs, 468.303 µs] 73.97 µs (19.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/improve-servicenamecollector
git_commit_date 1734517793 1734540744
git_commit_sha a19f73a da89e60
release_version 1.45.0-SNAPSHOT~a19f73a5ea 1.45.0-SNAPSHOT~da89e60163
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1734542723 1734542723
ci_job_id 744262692 744262692
ci_pipeline_id 51472866 51472866
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.342 ms) : 2301, 2384
.   : milestone, 2342,
iast (2.085 ms) : 2032, 2137
.   : milestone, 2085,
iast_GLOBAL (2.127 ms) : 2074, 2179
.   : milestone, 2127,
profiling (1.959 ms) : 1916, 2001
.   : milestone, 1959,
tracing (1.936 ms) : 1895, 1977
.   : milestone, 1936,
section candidate
no_agent (1.466 ms) : 1455, 1478
.   : milestone, 1466,
appsec (2.343 ms) : 2302, 2384
.   : milestone, 2343,
iast (2.081 ms) : 2028, 2133
.   : milestone, 2081,
iast_GLOBAL (2.138 ms) : 2085, 2191
.   : milestone, 2138,
profiling (1.977 ms) : 1934, 2021
.   : milestone, 1977,
tracing (1.922 ms) : 1882, 1962
.   : milestone, 1922,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.342 ms [2.301 ms, 2.384 ms] 871.083 µs (59.2%)
iast 2.085 ms [2.032 ms, 2.137 ms] 613.298 µs (41.7%)
iast_GLOBAL 2.127 ms [2.074 ms, 2.179 ms] 655.387 µs (44.5%)
profiling 1.959 ms [1.916 ms, 2.001 ms] 487.506 µs (33.1%)
tracing 1.936 ms [1.895 ms, 1.977 ms] 464.642 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.478 ms] -
appsec 2.343 ms [2.302 ms, 2.384 ms] 876.98 µs (59.8%)
iast 2.081 ms [2.028 ms, 2.133 ms] 614.6 µs (41.9%)
iast_GLOBAL 2.138 ms [2.085 ms, 2.191 ms] 671.772 µs (45.8%)
profiling 1.977 ms [1.934 ms, 2.021 ms] 511.074 µs (34.9%)
tracing 1.922 ms [1.882 ms, 1.962 ms] 455.925 µs (31.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~da89e60163, baseline=1.45.0-SNAPSHOT~a19f73a5ea
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
appsec (14.905 s) : 14905000, 14905000
.   : milestone, 14905000,
iast (18.776 s) : 18776000, 18776000
.   : milestone, 18776000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (14.782 s) : 14782000, 14782000
.   : milestone, 14782000,
tracing (15.067 s) : 15067000, 15067000
.   : milestone, 15067000,
section candidate
no_agent (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
appsec (15.161 s) : 15161000, 15161000
.   : milestone, 15161000,
iast (18.847 s) : 18847000, 18847000
.   : milestone, 18847000,
iast_GLOBAL (17.739 s) : 17739000, 17739000
.   : milestone, 17739000,
profiling (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,
tracing (15.105 s) : 15105000, 15105000
.   : milestone, 15105000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.99 s [14.99 s, 14.99 s] -
appsec 14.905 s [14.905 s, 14.905 s] -85.0 ms (-0.6%)
iast 18.776 s [18.776 s, 18.776 s] 3.786 s (25.3%)
iast_GLOBAL 17.985 s [17.985 s, 17.985 s] 2.995 s (20.0%)
profiling 14.782 s [14.782 s, 14.782 s] -208.0 ms (-1.4%)
tracing 15.067 s [15.067 s, 15.067 s] 77.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.969 s [14.969 s, 14.969 s] -
appsec 15.161 s [15.161 s, 15.161 s] 192.0 ms (1.3%)
iast 18.847 s [18.847 s, 18.847 s] 3.878 s (25.9%)
iast_GLOBAL 17.739 s [17.739 s, 17.739 s] 2.77 s (18.5%)
profiling 15.07 s [15.07 s, 15.07 s] 101.0 ms (0.7%)
tracing 15.105 s [15.105 s, 15.105 s] 136.0 ms (0.9%)

@amarziali amarziali requested a review from mcculls December 19, 2024 07:36
@amarziali amarziali enabled auto-merge (squash) December 19, 2024 07:36
@amarziali amarziali merged commit 30bb13b into master Dec 20, 2024
149 checks passed
@amarziali amarziali deleted the andrea.marziali/improve-servicenamecollector branch December 20, 2024 09:00
@github-actions github-actions bot added this to the 1.45.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core type: enhancement
Projects
None yet
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @mcculls