Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing platform directive #16

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add missing platform directive #16

merged 1 commit into from
Nov 20, 2024

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Nov 20, 2024

Overlooked that engines/ruby:2.1-musl behaves like engines/ruby:2.2-musl.

This impacts, say, rake docker build[**:*] but not CI since is is currently hardcoded in the workflow matrix.

@lloeki lloeki requested a review from a team as a code owner November 20, 2024 09:39
Base automatically changed from lloeki/add-centos-images to main November 20, 2024 10:49
@lloeki lloeki merged commit 5dfc960 into main Nov 20, 2024
35 of 37 checks passed
@lloeki lloeki deleted the lloeki/add-missing-platform-directive branch November 20, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyCTHsu TonyCTHsu TonyCTHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lloeki @TonyCTHsu