Remove explicit use of hyper in integration/ducks #1179
+128
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
GeorgeHahn
approved these changes
Dec 23, 2024
blt
force-pushed
the
blt/update_clap_minor_version
branch
from
14f19e3 to
b49c30d
Compare
blt
force-pushed
the
blt/remove_explicit_use_of_hyper_in_integration_ducks
branch
from
1c0cc5a to
054910d
Compare
blt
force-pushed
the
blt/update_clap_minor_version
branch
2 times, most recently
from
d17e86b to
7645062
Compare
blt
force-pushed
the
blt/remove_explicit_use_of_hyper_in_integration_ducks
branch
from
054910d to
7a574f9
Compare
blt
changed the base branch from
blt/update_clap_minor_version
to
graphite-base/1179
blt
force-pushed
the
blt/remove_explicit_use_of_hyper_in_integration_ducks
branch
from
7a574f9 to
387efe2
Compare
blt
force-pushed
the
graphite-base/1179
branch
from
7645062 to
ea1a646
Compare
blt
force-pushed
the
blt/remove_explicit_use_of_hyper_in_integration_ducks
branch
from
387efe2 to
e7dc28f
Compare
I can't figure out how to update hyper in our project given the set of interlinked crates that all have to update in one shot. As a result, I'm removing explicit references to hyper and started with ducks. This commit also removes the tower layers as it was not clear to me that these are required for integration test purposes. Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/remove_explicit_use_of_hyper_in_integration_ducks
branch
from
e7dc28f to
ef730a4
Compare
blt
added a commit
that referenced
this pull request
Dec 24, 2024
This commit is peer to #1179 and takes an alternative approach: only upgrade hyper et al in single spots in the project. This means we have a mix of different hyper versions et al but it does compile at least. This is a wretched mess. I couldn't make tower work in ducks so it's dropped -- we'll need to add load shedding and concurrency control ourselves if we want it -- and while it's cool that hyper is now a 1.0 crate I really, really don't love that we depend on a small set of 0.1 crates to get there. I don't know if I would rather just opt into axum or not, although hyper at least will be a going concern in the ecosystem with high probability. Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I can't figure out how to update hyper in our project given the
set of interlinked crates that all have to update in one shot. As
a result, I'm removing explicit references to hyper and started with
ducks. This commit also removes the tower layers as it was not clear
to me that these are required for integration test purposes.