Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporter: always append remote_symbols:yes tag #27

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Gandem
Copy link
Member

@Gandem Gandem commented Jun 25, 2024

Always append remote_symbols:yes as a tag in the profiler

@Gandem Gandem requested review from nsavoire and r1viollet June 25, 2024 10:21
r1viollet
r1viollet previously approved these changes Jun 25, 2024
Copy link
Collaborator

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from nayef/local-symbols to main June 25, 2024 11:59
@Gandem Gandem dismissed r1viollet’s stale review June 25, 2024 11:59

The base branch was changed.

@Gandem Gandem force-pushed the nayef/remote-symbols branch from 7c64def to 2201c2d Compare June 25, 2024 13:15
@Gandem Gandem requested a review from r1viollet June 25, 2024 13:15
@Gandem Gandem merged commit 7f81160 into main Jun 25, 2024
5 checks passed
@Gandem Gandem deleted the nayef/remote-symbols branch June 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants