symbolication: reduce error logs for local symbol upload [PROF-10143] #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandem
force-pushed
the
nayef/symbol-upload
branch
3 times, most recently
from
afdc567 to
85756b8
Compare
Gandem
changed the title
Gandem
force-pushed
the
nayef/symbol-upload
branch
3 times, most recently
from
3596058 to
8a5165f
Compare
we're seeing sporadic timeouts on internal fleets, splitting timeouts to give both the extraction and the upload a bit more headroom
Gandem
force-pushed
the
nayef/symbol-upload
branch
from
8a5165f to
85fc1b0
Compare
short lived executables might no longer exist by the time we want to copy symbols, this hopefully reduces the amount of error logs that the uploader outputs for those executables
Gandem
force-pushed
the
nayef/symbol-upload
branch
from
85fc1b0 to
d0d80b6
Compare
nsavoire
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce error logs for local symbol upload by:
Best reviewed commit by commit!
@DataDog/profiling-full-host