Thread files from image's ancestors all the way through to it's output #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you construct images by layering them on top of one another, e.g.
You want the images to keep passing the files of their ancestors along the chain.
This is not expensive (because we are using
depset
) and it will enable future improvements, in particular writing anoci_image_tar
rule that knows how to turn anoci_image
target into a tar file that conforms to the OCI Image Layout spec and can be loaded into local Docker. This PR sets the groundwork for that kind of functionality since, with this change,image2
's output in the above example will now contain all the files from@base//image
,layer1
andlayer2
, which are all required to create a tarball. Before this change,image2
's output only contains the files fromlayer2