Reindent files. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenjiTakahashi
suggested changes
Apr 8, 2018
There was a problem hiding this comment.
Hello, thanks for the PR and sorry for such a long delay!
I very much understand the premise to standardize the indents. It is kinda crazy to work on this, when every file seems to be written in completely different style ;-].
You've used some kind of tool to achieve this, right? It seems that it got confused in a couple of places. Apart from these, it looks fine.
| net0: network, | ||
| description: desc, | ||
| agent: get_rest_boolean(config.qemu_agent), | ||
| pool: config.pool |
| cpuunits: config.lxc_cpuunits, | ||
| swap: config.lxc_swap, | ||
| tty: config.lxc_tty, | ||
| pool: config.pool |
| .flatten | ||
| .select { |ip| ip[:'ip-address-type'] == 'ipv4' } | ||
| .map { |ip| ip[:'ip-address'] } | ||
| .first |
There was a problem hiding this comment.
I'd say that these should stay indented, so that we know they're part of the chain and not separate statements.
| .first | ||
| .select { |m| m[:id] =~ /^[a-z]*\/#{vm_id}$/ } | ||
| .map { |m| { id: vm_id, type: /^(.*)\/(.*)$/.match(m[:id])[1], node: m[:node] } } | ||
| .first |
| params[:protection] = get_rest_boolean(config.lxc_protection) | ||
| params[:console] = get_rest_boolean(config.lxc_console) | ||
| add_lxc_network_config(env, params) | ||
| add_lxc_mount_points(env, config, params) |
There was a problem hiding this comment.
And here it seemed to have got confused by \ at :113. The indent should stay as it was. [The usage of \ is ugly, but I'm not the one to blame here ;-).]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only reindents files to two spaces per block, no code has been changed.