Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4.* #38

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

mkoprek
Copy link

@mkoprek mkoprek commented Oct 12, 2024

No description provided.

@mkoprek
Copy link
Author

mkoprek commented Oct 16, 2024

Require: vimeo/psalm#10928

@DaveLiddament
Copy link
Owner

@mkoprek Thanks for your help with this PR. Really appreciate your help on it.

Given this project only contains attributes, I wonder if having both PHPStan and Psalm is overkill?

Options I see:

  • Remove Psalm from CI, and get this merged. We can create a separate PR with Psalm enabled and merge that once the Psalm PR is sorted.
  • Wait until PHP 8.4 is released.

The benefit of the first option is the phpstan rules for this can be upgraded for 8.4.

Have you any thoughts on the above, or a better suggestion?

@mkoprek
Copy link
Author

mkoprek commented Oct 17, 2024

Hey,

From mine personal perspective I think using both tools is an overkill.
We are using in all projects phpstan and it is doing it job very well.

I would choose option one, I will push code with changes for it.

Thanks for fast response :)

@DaveLiddament DaveLiddament merged commit 337f3d4 into DaveLiddament:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants