Add parameter filterset to filterset_factory #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are already failing on master branch (at least on my machine ... but with the same error message). I don't understand, how these (yaml) tests work ... 😢 |
added 3 commits
December 15, 2024 17:21
The parameter filterset has been added in version 24.1
default value of lookup_expr is None, therefore it should have the respective type
DavisRayM
force-pushed
the
fix/filterset_factory
branch
from
1d707c7 to
07ad688
Compare
DavisRayM
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterset_factorygot a new parameter in version 24.1.Additionally I fixed the type annotation of parameter
lookup_exprindjango_filters.filterset.BaseFilterSet.filter_for_field