Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for NoneType Error in SSLyze parser #9850

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

manuel-sommer
Copy link
Contributor

@manuel-sommer manuel-sommer commented Apr 1, 2024

fixes #9848

I copied an exisiting unittestfile and changed the value of "heartbleed" to null to reproduce the issue. Then, I fixed the code.

Copy link

dryrunsecurity bot commented Apr 1, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

@manuel-sommer
Copy link
Contributor Author

I reproduced the error in the first commit and will it fix now.

@manuel-sommer manuel-sommer marked this pull request as ready for review April 1, 2024 09:38
@github-actions github-actions bot added the parser label Apr 1, 2024
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 15067de into DefectDojo:bugfix Apr 8, 2024
121 checks passed
@manuel-sommer manuel-sommer deleted the fix_issue_9848 branch April 8, 2024 14:40
hblankenship pushed a commit to hblankenship/django-DefectDojo that referenced this pull request Apr 26, 2024
* reproduce failure

* 🐛 fixed the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants