-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bitcoin #12560
base: main
Are you sure you want to change the base?
added bitcoin #12560
Conversation
Error while running adapter at projects/fluidtokens:
|
Error while running adapter at projects/fluidtokens:
|
Error while running adapter at projects/fluidtokens:
|
The adapter at projects/fluidtokens exports TVL:
|
@g1nt0ki I think I am doing something wrong here, I should have around 500k $ of Bitcoin TVL from the API, but I think I am not defining it in the right way now that I added bitcoin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this will duplicate tvl between bitcoin & cardano
you need to create a new tvl function for bitcoin, also, for bitcoin, we need the staking addresses, we dont accept api for it, you can add your protocol addresses here:
https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/helper/bitcoin-book/index.js
and use it like: https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/chakra/index.js#L6
The adapter at projects/fluidtokens exports TVL:
|
@g1nt0ki managed to fix, thanks a lot However we have a not-custodial time lock script, so every user has his own address, like shown at this link https://api2.fluidtokens.com/get-stake-amount-addresses?nameStakeVault=RAREPUPSPUPCASH We are similar to what Babylon is doing https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/babylon/index.js and I see they also use a API, probably for the same reason, many addresses to track |
hi @elRaulito we missed babylon, and currently pushing them to share bitcoin address list like the rest of the protocols. Thought a bit more about this, think it is better to create new listing for bitcoin staking part. then we will create parent listing for you, like we have for aave: https://defillama.com/protocol/aave This is just for my curiosity, how does the locking work? it is not like bitcoin supports proper scripting/smart contracts |
thanks a lot @g1nt0ki Then I should wait for an update on your side right? |
@g1nt0ki completly missed the question
Tldr: Bitcoin allow to say I won't spend this until X date, project can verify it onchain and reward users that do it |
The adapter at projects/fluidtokens exports TVL:
|
got it. still feels like it is a different product to what we have listed now, can you create a new adapter and compute tvl on chain using calls to bitcoin chain, you can use this method to compute brc20 token tvl: https://github.com/DefiLlama/DefiLlama-Adapters/blob/main/projects/helper/chain/brc20.js#L6 |
@g1nt0ki won't it eventually go in time-out? we have more or less 1000 users, each of them has their address to stake and we should compute the sum of the TVL We can even provide the list of all these addresses and the tvl of each of them if that's required, we just don't want to slow down on your side |
yeah, list of addresses and balances would be really helpful, thanks, this way, even if the api is not reachable, we will be able to compute tvl (I will cache your api response) |
another reason why we prefer the address and balance list is, we want to price tokens using our coins api, this way all projects use the same token price and users can see token breakdown of a project |
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIName (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):