Change Uniswap v3 subgraph queries to use pagination #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- filter out Uniswap v2 pools that can be duplicated in Uniswap v3
|
Tests are failing because of missing I tested it on forked repo on copied Of course workflow |
|
@rav-ipor ty. issue with this version is runtime, which for me locally was almost 15min which is way to long. if u can explore a faster version of this that be appreciated |
|
@slasher125 ok, I will try to speed it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniswap v3 adapter is fetching only first 1000 pools from subgraph for every chain. Because of that it misses many pools with >10k TVL.
In this PR, adapter fetches all Uniswap v3 pools from subgraph with pagination and filter out pools with less then 10k TVL.
Uniswap v2 pools are filtered out, because some of them are duplicated in both subgraphs used in Uniswap v2 and Uniswap v3 adapters.