Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to constructor when registering constructor #267

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

richarddd
Copy link
Contributor

Name property is not set when creating constructors. This PR adds the name from the class to the constructor so the following will work for classes defined in Rust.

new MyClass().constructor.name == "MyClass"

@richarddd richarddd changed the title Add name to ctor when registering constructor Add name to constructor when registering constructor Feb 20, 2024
Copy link
Owner

@DelSkayn DelSkayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@DelSkayn DelSkayn merged commit 9716bbb into DelSkayn:master Feb 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants