Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure promise polls spawner #312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

richarddd
Copy link
Contributor

@richarddd richarddd commented May 13, 2024

Promise converted into a future will now advance spawned tasks

@richarddd richarddd marked this pull request as ready for review May 13, 2024 11:44
@richarddd richarddd mentioned this pull request May 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.33%. Comparing base (304db5d) to head (cc1dfce).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   68.31%   68.33%   +0.01%     
==========================================
  Files          83       83              
  Lines       12237    12243       +6     
==========================================
+ Hits         8360     8366       +6     
  Misses       3877     3877              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richarddd
Copy link
Contributor Author

@DelSkayn can we merge this if put behind a feature flag?

@richarddd
Copy link
Contributor Author

@DelSkayn this is now gated behind promise_poll_spawner. Would that be OK?

@DelSkayn
Copy link
Owner

DelSkayn commented Dec 2, 2024

There is currently still an issue on this PR. It is possible for a task to become unblocked while it is polling, which would allow it to poll itself, finish and then free it's own task.

@richarddd
Copy link
Contributor Author

There is currently still an issue on this PR. It is possible for a task to become unblocked while it is polling, which would allow it to poll itself, finish and then free it's own task.

Can we track this somehow? Or add primitives to prevent this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants