-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure promise polls spawner #312
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 68.31% 68.33% +0.01%
==========================================
Files 83 83
Lines 12237 12243 +6
==========================================
+ Hits 8360 8366 +6
Misses 3877 3877 ☔ View full report in Codecov by Sentry. |
@DelSkayn can we merge this if put behind a feature flag? |
cc1dfce
to
9bdb520
Compare
@DelSkayn this is now gated behind |
There is currently still an issue on this PR. It is possible for a task to become unblocked while it is polling, which would allow it to poll itself, finish and then free it's own task. |
Can we track this somehow? Or add primitives to prevent this? |
Promise converted into a future will now advance spawned tasks