Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Adding Gatsby CMS #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP - Adding Gatsby CMS #43

wants to merge 2 commits into from

Conversation

imcodingideas
Copy link
Contributor

@imcodingideas imcodingideas commented Oct 11, 2018

Description

Working on a migrating the meetup events to Gatsby cms v2 which I needed to upgrade to the latest version of Gatsby.

Fixes # #39

Type of change

  • New feature (Breaking change which adds functionality)

How Has This Been Tested?

  • Adds new event
  • Runs gatsby build
  • Has no events

Proposal

I feel like we should show two lists of events:

  1. Upcoming Events
  2. Previous Events

screenshot 2018-10-11 13 05 47

@sixlive
Copy link
Member

sixlive commented Oct 16, 2018

So is this setup to use Netlify CMS? https://www.gatsbyjs.org/docs/sourcing-from-netlify-cms

@imcodingideas
Copy link
Contributor Author

imcodingideas commented Oct 17, 2018

@sixlive yes! However, I'm proposing something different and before I do it I wanted to get your feedback.

Show Upcoming
Show Previous Meetups

Right now on the current website if there are no upcoming it doesn't show anything at all.

I'm blocked to see if we still want: "no meetup" - as that's not implemented yet.

@imcodingideas
Copy link
Contributor Author

@sixlive I would like to get this merged in. If I resolve the new merge conflicts, can we have a discussion on how to move forward to getting this PR merged?

@sixlive
Copy link
Member

sixlive commented Jan 4, 2019

Hey! Steve and I have stepped down for running the organization. I think running this through @Swampy821 would be best as I think he might have some new plans for the site.

@imcodingideas
Copy link
Contributor Author

@Swampy821 hey steve! Let me know how I can help with the site. There was a task here to add gatsby cms but it seems the awesome @QueueHammer is pulling the events from the meetup api:

382794c

So we may not even need Gatsby CMS.

@QueueHammer
Copy link
Contributor

QueueHammer commented Jan 8, 2019

@imcodingideas are you in the Slack channel? When I made the update, the url the site was calling as a proxy for meetup was not working, which I assumed was because without auth you couldn't call the API without a CORS error. However, I remember from a long, long, time ago that their api also supported JSONP. I think there is a lot of opportunity to improve the site, so let's keep this conversation going in Slack

@imcodingideas
Copy link
Contributor Author

@QueueHammer yes, I'm on the slack channel. I'm codingideas on the channel. Reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants