Always start minitouch agent #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koral--
approved these changes
Jul 13, 2020
|
@4c0n LGTM, but DCO check has not passed. Sign-off is missing. |
|
This one: 3e74556 has no sign-off. |
|
Amending the sign off created that new commit.though. I can try to rebase to get rid of the original one tomorrow. |
4c0n
force-pushed
the
feature/always-start-minitouch-agent
branch
2 times, most recently
from
2fa3276 to
2eaf7c7
Compare
Signed-off-by: Youri Westerman <[email protected]>
4c0n
force-pushed
the
feature/always-start-minitouch-agent
branch
from
2eaf7c7 to
cf8d166
Compare
|
@koral-- Alright it took some forcing, but it should be okay now 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to suggest that the minitouch agent always be started, not just for Android Q.
That way we can use it when devices don't have a libevdev multi touch input device.
As such openstf/minitouch#15 can be closed, as we now have a better solution.
My personal use case is that I need stf to be able to remotely control my Android devices running without a (working) touch screen. (Using the boards of old phones to turn them into remotely operated vehicles)