Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial state widgets forced to sum to 1 even if not appropriate / incorrect error message methodology used #317

Closed
jarmarshall opened this issue Apr 4, 2019 · 1 comment · Fixed by #354
Closed

initial state widgets forced to sum to 1 even if not appropriate / incorrect error message methodology used #317

jarmarshall opened this issue Apr 4, 2019 · 1 comment · Fixed by #354
Assignees
@joefresna
Labels
bug
Milestone
First release patch

Comments

@jarmarshall
Copy link
Contributor

jarmarshall commented Apr 4, 2019 •
edited
Loading

In _format_advanced_option() initial state widgets are forced to sum to 1 without checking if this is appropriate; if the system is not conserved _constantSystemSize == None or == False then user-provided values should not be altered

Additionally, the warning message is printed; the appropriate way to raise errors such as this is via the _errorMessage widget, accessed via _showErrorMessage()
@jarmarshall jarmarshall added the bug label Apr 4, 2019
@jarmarshall jarmarshall added this to the Second release milestone Apr 4, 2019
@jarmarshall jarmarshall mentioned this issue Apr 4, 2019
Closed
@joefresna
Copy link
Contributor

Problem with exceptions and warnings has a dedicated issue #352

joefresna pushed a commit that referenced this issue Sep 27, 2019
Added possibility to have initial state >1 for integrate() and bifurc…
7c6a869 
…ation(). For multiagent() and SSA() the widgets are still limited to the sum of 1.

This fixes #318 #317
joefresna pushed a commit that referenced this issue Sep 27, 2019
Forcing sum to 1 for all views #317 #318
890f53f
@joefresna joefresna mentioned this issue Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joefresna joefresna

Labels
bug
Projects
None yet
Milestone
First release patch
Development

Successfully merging a pull request may close this issue.

Fix sum to1 state DiODeProject/MuMoT
2 participants
@joefresna @jarmarshall