Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sum to1 state #354

Merged
merged 6 commits into from
Sep 30, 2019
Merged

Fix sum to1 state #354

merged 6 commits into from
Sep 30, 2019

Conversation

joefresna
Copy link
Contributor

Fix #317 #318

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #354 into master will increase coverage by 0.1%.
The diff coverage is 52.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #354     +/-   ##
=========================================
+ Coverage   68.98%   69.08%   +0.1%     
=========================================
  Files           9        9             
  Lines        5774     5780      +6     
  Branches     1576     1583      +7     
=========================================
+ Hits         3983     3993     +10     
+ Misses       1397     1389      -8     
- Partials      394      398      +4
Impacted Files Coverage Δ
mumot/views.py 66.23% <0%> (+0.03%) ⬆️
mumot/controllers.py 78.05% <0%> (-0.15%) ⬇️
mumot/utils.py 69.93% <54.16%> (+2.22%) ⬆️
mumot/models.py 71.96% <64.28%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ebb62...ab14ba2. Read the comment docs.

Copy link
Contributor

@jarmarshall jarmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've forced all proportions to sum to 1 for now as the distinction between views is not clear to me in this regard; the logic is there for relaxing the sum rule though and can be applied in the future if deemed useful.
I've also implemented warnings properly, via warn()... this should be non-blocking

@jarmarshall jarmarshall merged commit 0e2c8b4 into master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initial state widgets forced to sum to 1 even if not appropriate / incorrect error message methodology used
3 participants