update navbar styling, and fix broken links #1386
Open
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamGoel
changed the title
JyotinderSingh
requested changes
Dec 21, 2024
docs/src/components/Nav.astro
Outdated
| > | ||
| <span class="has-text-weight-bold"> Playground</span> | ||
| </a> | ||
| <div class="navbar-end" style="gap:0.3rem;"> |
There was a problem hiding this comment.
better not to use inline style definitions like this. Please keep styling consistent with existing practices.
There was a problem hiding this comment.
For gap, I could find 2 options.
- Adding
gap:0.3remon.navbar-endinmain.css. - Adding
mr-1(for desktop), andmb-1(for <1024px) on each link in navbar.
I prefer the first one, so pushed that. Let me know if you can think of another approach to better handle this
docs/src/styles/main.scss
Outdated
| @media screen and (max-width: 1024px) { | ||
| .navbar-item { | ||
| margin-top: 0.3em; | ||
| display: flex !important; |
There was a problem hiding this comment.
using !important declaratives is not a good practice and reflects misplaced CSS elsewhere. We should try to avoid this.
RamGoel
changed the title
|
Also added a fix for broken link on apologies for mixing up things in this PR. I'll try to keep clean from next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling Updates
Broken Links
DiceDB is now open sourceblog, fix the team page redirect, onourtext.Final