Added --ac-only argument to start autoupdate only when device is not running on battery power #112
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Not stale! This PR would be very helpful to get merged in :-) |
| ac_only = if args.ac_only? | ||
| <<~EOS | ||
| if [[ $(pmset -g ps | head -1) =~ "Battery Power" ]]; then | ||
| echo "Not starting autoupdate, because device is running on Battery" |
There was a problem hiding this comment.
Does this print to the applet notification? Will the user be notified essentially that Autoupdate hasn't actually been run?
There was a problem hiding this comment.
The whole autoupdate script will not run, so no applet notification will be shown.
The users will not be notified.
There was a problem hiding this comment.
Does the autoupdate script ever start or is it essentially "stuck" until the user tries to activate it again? That's my only concern here.
There was a problem hiding this comment.
This time, I'm sorry for the late reply, totally missed it.
It will only run, if the user ever again plugs in power (what he's very likely to do since he want's to continue using the device) and another trigger (reboot or time) initiates the execution of the autoupdate script.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Relax robot. Will set aside some time tomorrow to review again. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
not stale |
Solves issue: #94