Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance output of status command #113

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

swissbuechi
Copy link
Contributor

Solves issue: #38

image

@swissbuechi swissbuechi marked this pull request as draft October 27, 2023 12:00
@swissbuechi swissbuechi marked this pull request as ready for review October 27, 2023 18:03
@swissbuechi swissbuechi deleted the enhance-output-of-status-command branch November 10, 2023 20:28
@swissbuechi swissbuechi restored the enhance-output-of-status-command branch November 10, 2023 21:39
@swissbuechi
Copy link
Contributor Author

Accidentally deleted wrong branch...

@swissbuechi swissbuechi reopened this Nov 10, 2023
@swissbuechi
Copy link
Contributor Author

I added the output of the new --sudo argument:

image

@swissbuechi swissbuechi marked this pull request as draft December 7, 2023 14:36
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Dec 29, 2023
@DomT4
Copy link
Owner

DomT4 commented Dec 29, 2023

Is there any appreciable slowdown in the command invocation in pulling the additional information? Beyond that question and this needing rebasing, no objection though. Makes enough sense to me. Apologies for the slow review on these.

@github-actions github-actions bot removed the Stale label Dec 29, 2023
@swissbuechi
Copy link
Contributor Author

swissbuechi commented Dec 29, 2023

Apologies for the slow review on these.

No need to apologize, I've literally spammed you with PR's...


Is there any appreciable slowdown in the command invocation in pulling the additional information?

No, the XML is parsed within milliseconds and the command output still immediately displays on my M1 Pro.


this needing rebasing

Yes, I know. All of a sudden, there was an issue with the required import for the XML parsing:

Error: cannot load such file -- rexml/document - in status.rb line 3

It worked just fine a few weeks ago. I will now try to implement the XML parsing in native ruby or maybe fix the dependency import.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 20, 2024
@DomT4
Copy link
Owner

DomT4 commented Jan 20, 2024

Relax robot. Will set aside some time tomorrow to review again.

Did we manage to solve the XML loading issue?

@swissbuechi
Copy link
Contributor Author

I haven't figured out yet how I can import a dependency in the gemfile.

Seems like there is no gemfile because homebrew-autouodate is just an add-on module?

I really don't understand ruby and the whole homebrew project well enought.

Will try to understand both a little better and fix the issue.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Feb 12, 2024
@swissbuechi
Copy link
Contributor Author

not stale

@github-actions github-actions bot removed the Stale label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants