Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignore file configuration #1

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

danteay
Copy link
Contributor

@danteay danteay commented Nov 22, 2023

Description

Add new options to configure an ignore file to create rules that allows to skip the check on certain keys if the file matches with the specified ignore pattern.

Task Context

What is the current behavior?

  • No way to skip check on specific keys

What is the new behavior?

  • New action argument ignore_file that represents a path to an ignore json file for the action (default is .json-diff-ignore.json on project root)

Additional Context

Struct of the ignore file:

[
  {
    "pattern": "regexp/file\\.json$",
    "ignoreKeys": ["key1"]
  },
  {
    "pattern": "regexp/file2\\.json$",
    "ignoreKeys": ["key2"]
  }
]

@danteay danteay merged commit f318e61 into main Nov 22, 2023
3 checks passed
@danteay danteay deleted the feat/add-ignore-file branch November 22, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants