Implements simple k8s API retries #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also tweaked some parameter names
johnbradley
reviewed
Oct 9, 2019
- 404 means pod not found, so the deletion is unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses tenacity to retry API calls that may fail due to temporary unavailable k8s API
This work was intended to tolerate automated GKE cluster master upgrades (during which the API server is unavailable). While it addresses that and continues the workflow after the API server returns, the upgrade/autoscaling was causing nodes to delete running pods and terminate them prematurely.
In the interest of seeing a large workflow run, we'll not use auto-scaling on GKE for now, and revisit this later if necessary.
Fixes the
APIExceptions, andConnectionErrors related to #96. TheError Collecting Outputissues were occurring in my testing when a GKE node was killed and terminated pods running on it.