Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures intermediate directories exist prior to redirecting stdout/stderr #92

Closed
wants to merge 5 commits into from
Closed

Ensures intermediate directories exist prior to redirecting stdout/stderr #92

wants to merge 5 commits into from

Conversation

dleehr
Copy link
Member

@dleehr dleehr commented Jul 25, 2019

  • Checks if job.stdout or job.stderr are paths within directories
  • Adds an initContainer to the Pod spec if these are directories, and creates them

WIP, For #8

dleehr added 5 commits July 25, 2019 15:20
@dleehr
Create redirection directories if needed with an initContainer
05c08e2 
- moves arg list quoting to quoted_arg_list function
- Adds fields/properties for init container stuff
- Checks `os.path.dirname` of stdout/stderr to see if any directories may need to exist
- Uses alpine image for now, but will switch to default-container
@dleehr
Filter out empty string dirnames
e865281
@dleehr
Tests for initContainers and quoted_arg_list function
df9c307
@dleehr
Remove hard-coded alpine image for builder default
e60f68b 
- Need to update tests
@dleehr
Update tests for using default-container as initContainer image
3bf48a0 
- default-container is basically required now
@dleehr dleehr closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dleehr