Adds initContainer to ensure stdout/stderr directories exist #93

dleehr · 2019-08-01T20:17:06Z

Checks if job.stdout or job.stderr are paths within directories
Adds an initContainer to the Pod spec if these are directories, and creates them before attempting redirection inside the primary container

for #8

- moves arg list quoting to quoted_arg_list function - Adds fields/properties for init container stuff - Checks `os.path.dirname` of stdout/stderr to see if any directories may need to exist - Uses alpine image for now, but will switch to default-container

- Mocking the entire module caused other behavior reliant on os to fail

johnbradley

LGTM

dleehr added 5 commits July 25, 2019 15:20

Filter out empty string dirnames

e865281

Tests for initContainers and quoted_arg_list function

df9c307

Makes init image customizable by setting env variable

a12df0f

Fix tests by mocking os.environ.get instead of os

5e55a7a

- Mocking the entire module caused other behavior reliant on os to fail

dleehr requested a review from johnbradley August 1, 2019 20:18

johnbradley approved these changes Aug 1, 2019

View reviewed changes

dleehr merged commit 8d1fd99 into master Aug 2, 2019

dleehr deleted the 8-initcontainer-for-redirect branch August 2, 2019 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds initContainer to ensure stdout/stderr directories exist #93

Adds initContainer to ensure stdout/stderr directories exist #93

dleehr commented Aug 1, 2019

johnbradley left a comment

Adds initContainer to ensure stdout/stderr directories exist #93

Adds initContainer to ensure stdout/stderr directories exist #93

Conversation

dleehr commented Aug 1, 2019

johnbradley left a comment

Choose a reason for hiding this comment