Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh CI: add conda/mamba environment file and modern env creation, fix tests, and add modern Github Action workflow file #95

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

bouweandela
Copy link
Collaborator

  • Update tests to use modern Python versions
  • Enable nightly test runs

@bouweandela
Copy link
Collaborator Author

It looks like the tests heavily rely on the availability of the CEDA ESGF index node, so let's wait until that comes back online.

Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want me to take over this PR, bud? If you don't have time, that is. It's well needed 😁

@valeriupredoi valeriupredoi marked this pull request as ready for review November 28, 2023 17:56
@valeriupredoi
Copy link
Collaborator

OK fairly serious upgrades here:

  • a working conda/mamba environment that makes requirements and requirements_dev obsolete
  • a decent testing environment built from conda-forge;
  • fixes to a few tests;
  • removal of old way of getting pandoc; notebook and docs build well for all Python versions

CAVEAT tests/test_results.py is pretty broken (I didn't break it, it was already when I took over this), so I turned it off for now, so that we have a modicum of tests run on PRs and nightly; those need fixed, but I don't have the expertise ro do it, so I'll open a PR 👍

@valeriupredoi valeriupredoi changed the title Refresh CI Refresh CI: add conda/mamba environment file and modern env creation, fix tests, and add modern Github Action workflow file Nov 28, 2023
@valeriupredoi valeriupredoi merged commit 9ad147b into master Nov 28, 2023
5 checks passed
@valeriupredoi valeriupredoi deleted the refresh-ci branch November 28, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants