-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci prusse test #152
Draft
prusse-martin
wants to merge
22
commits into
master
Choose a base branch
from
fix-ci-prusse-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix ci prusse test #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing-extensions 4.2.0 is not compatible with Python 3.6, and breaks `pytest`.
`5.10` (the latst version) seems to be incompatible with `jaraco.text`, which is an indirect dependency of `cherrypy`. Fix #151
The variables were incorrectly defined, resulting in all builds being done in Python 3.6.
To test in all platforms we cannot pin to 5.12, as it is not available in later Pythons.
This should not be needed anymore, installing from conda-forge is sufficient.
When changing from phantomsj to firefox the messages started to be prefixed with "ERROR: ". I could also have changed `SeleniumExtras.get_exception_message` to drop the prefix, in retrospect that would have been easier because the expected values will not have to be changed.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.