-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake components to neatly install individual libraries #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for your PR! Looks great for me
One negligible comment: may you update the README for users how to install both libraries with CMake components (like "sudo cmake --install qrcodegen-build --component qrcodegencpp
")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits to a single one and add a sign-off (you can use git commit -s
and the Git will handle it automatically).
We need signed-off commits for sending changes to the upstream.
Assign each file to the corresponding CMake component, one for the C library and another one for the C++ version. This enables install commands in the form: `cmake --install <build_dir> [--prefix <install_dir>] --component <component>` Signed-off-by: Filip Valgimigli <[email protected]>
Hi all, glad you appreciated it.
To @xvitaly, I've squashed the fix into the main commit and signed-off as requested, please just check if anything else is missing.
To @leha-bot, I've added the instructions concerning the CMake components, let me know if it blends well into the rest. Thanks to both, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks for your contribution.
My pleasure! Thank you all for reacting so quickly, I can keep pulling from upstream in my PKGBUILD. 😎 Hasta la vista! |
Dear maintainers,
as you might guess from the title, I've just specified the
COMPONENT
attribute for eachinstall()
directive.These are
qrcodegen
for the C library andqrcodegencpp
for the C++ implementation.This enables installing only one of the two library flavors with commands in the form:
cmake --install <build_dir> [--prefix <install_dir>] --component <component>
My use case for this is to produce split packages in a more elegant way. As an example, split packages for Arch Linux can be created with both libraries sharing a common build and test process, then they can be packaged separately without all those clean-up instructions (as seen in the qrcodegen-cmake AUR package).
Thanks for your time, hope you'll find it useful as well.
Cheers!