Fixed issue with Extenject bindings

Someone pointed me in the right direction, all works now :D
EcsRx · Mar 12, 2020 · 6226289 · 6226289
1 parent 472abb8
commit 6226289
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Assets/EcsRx.Examples/ManuallyRegisterSystems/Application.cs b/src/Assets/EcsRx.Examples/ManuallyRegisterSystems/Application.cs
@@ -12,7 +12,7 @@ public class Application : EcsRxApplicationBehaviour
         // We override this to stop auto bindings
         protected override void BindSystems()
         {
-            Container.Bind<ISystem, RandomMovementSystem>();
+            Container.Bind<RandomMovementSystem>();
         }
 
         // We override this to manually control how systems start

diff --git a/src/Assets/EcsRx/Zenject/Dependencies/ZenjectDependencyContainer.cs b/src/Assets/EcsRx/Zenject/Dependencies/ZenjectDependencyContainer.cs
@@ -39,6 +39,9 @@ public void Bind(Type fromType, Type toType, BindingConfiguration configuration
                 bindingSetup.To(toType).AsSingle();
                 return;
             }
+
+            if(!string.IsNullOrEmpty(configuration.WithName))
+            { bindingSetup.WithId(configuration.WithName); }
 
             if (configuration.ToInstance != null)
             {
@@ -63,10 +66,7 @@ public void Bind(Type fromType, Type toType, BindingConfiguration configuration
             }
 
             var binding = bindingSetup.To(toType);
-
-            if(!string.IsNullOrEmpty(configuration.WithName))
-            { binding.WithConcreteId(configuration.WithName); }
-
+
             if(configuration.AsSingleton)
             { binding.AsSingle(); }
 

diff --git a/src/Assets/Plugins/Editor/JetBrains/JetBrains.Rider.Unity.Editor.Plugin.Repacked.dll b/src/Assets/Plugins/Editor/JetBrains/JetBrains.Rider.Unity.Editor.Plugin.Repacked.dll