Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensembling over layers #259
base: main
Are you sure you want to change the base?
Ensembling over layers #259
Changes from 54 commits
934cd54
dff69bf
b181d3e
a493b85
af5def6
04a2a82
f433885
cda7de7
c9f2558
0ceaa3a
86fb1c8
47a3f60
0bd274f
04f0b4c
994af9b
6ca1916
b0d0f83
241a03a
e8d042a
a4ace25
b025c71
2156ad8
e391da6
449971f
528367d
d4df517
2661ea1
043aa7a
21cccb7
2495c3a
69af43c
908308b
fc980d7
5aa30a9
d5b8584
6380814
98d19b7
e6914e1
29b1cb8
421590c
bed615a
bf49e99
1f5d8be
03a37d2
ec37716
1936624
b243932
484788e
8c34797
ea5e9e8
c0545aa
b6de957
cf32b0c
769676a
e6c9d4c
8093294
6028152
6d7d99a
4148857
964f03d
f7ed262
06dad69
0d2545b
4a717ce
5952b4b
7efe38f
049cd63
c8236dd
56d1796
4d9c781
8961e95
bd06cd3
f8882c6
23183bc
d091f9d
776c186
9629ba5
45b527f
64e762a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in some ways I think we should allow the layers over which we ensemble to be configurable. E.g. sometimes the last layers perform worse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it makes sense to make it configurable. However, I'm curious, how would you decide which layers to pick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the ensembling is done by taking the mean over layers, rather than concatenating. This isn't super clear from comments/docstrings, and hard to tell from reading the code because the shapes aren't commented.