-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAJOR UPDATE: Remove CCS, VINC #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost good to go
@@ -185,7 +190,12 @@ def fit_cv( | |||
|
|||
@classmethod | |||
def inlp( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably just get rid of this. If we really want to explore the half-space of admissible predictors we should probably try the Conical Knowledge Decomposition thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have actually been using this occasionally, basically it just gives me a higher recall way of searching for good probes. Do you still think we should get rid of it?
"""Whether to use LEACE to erase the paraphrase dimensions before training the | ||
classifier.""" | ||
|
||
max_inlp_iter: int | None = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's drop this
@@ -185,7 +190,12 @@ def fit_cv( | |||
|
|||
@classmethod | |||
def inlp( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have actually been using this occasionally, basically it just gives me a higher recall way of searching for good probes. Do you still think we should get rid of it?
…args, fix answer token being appended, fix viz, fix tqdm propagation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge this bad boy
This PR does several major things to the repository:
InferenceServer
class is used to do inference, enabling FSDP (--fsdp
) inference with much larger modelsstatement + suffix
wherestatement
is the statement we're extracting hidden states from andsuffix
is a piece of text like "\n\nIs the above statement true or false?" that's optionally specified in the yaml template file--save_logprobs
--balance False
InferenceServer
InferenceServer
"_default"
which takes the"statement"
column itself