Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference server duplication check #294

Merged
merged 1 commit into from
Nov 2, 2023
Merged

inference server duplication check #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions elk/extraction/inference_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,18 @@ def imap(
q.put((closure_pkl, model_kwargs_pkl, shard))

generator = round_robin(self._result_queues) # type: ignore[arg-type]
seen_dummy = False
seen_ids = set()
for out in tqdm(generator, total=len(dataset), disable=not use_tqdm):
if out[0] == dummy_id:
if seen_dummy:
if dummy_id in seen_ids:
continue # ignore any extra dummy rows
else:
seen_dummy = True
elif out[0] in seen_ids:
raise RuntimeError(
"Round robin yielded duplicate items. "
"This may be due to multiprocessing queues returning "
"items repeatedly."
)
seen_ids.add(out[0])
yield out


Expand Down