New version 6.0.4 which updates Semantic Kernel to 1.0.0-beta8
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew" />` to version `1.0.0-beta8`. - Version of ENMARCHA changes from `6.0.3.20` to `6.0.4.0` - Added a CHANGELOG.md - Removed `NotSemanticFunction` exception message since now `Semantic Kernel` does not longer differentiates between Semantic and Native functions. Also the `ArgumentException` is not thrown anymore. This affects the following methods: * GetSemanticFunctionPromptAsync * GetSemanticFunctionUsedTokensAsync - Extension method `ImportQuestionAnsweringPlugin` from `Encamina.Enmarcha.SemanticKernel.Plugins.QuestionAnswering` now expects an `ISemanticTextMemory` as part of the required services. - Extension method `ImportMemoryPlugin` from `Encamina.Enmarcha.SemanticKernel.Plugins.Memory` now expects a valid instance of `ISemanticTextMemory` as input parameter. This breaks the previous signature of the method. - The constructor of the `MemoryQueryPlugin` class now expects a valid instance of `ISemanticTextMemory` instead of `IKernel`. This breaks the previous signature of the class constructor. - Due to changes form Semantic Kernel, the class `ChatRequestSettings` is replaced by `OpenAIRequestSettings` which breaks the previous signature of the `ChatRequestSettings` property of the `ChatWithHistoryPluginOptions` class in `Encamina.Enmarcha.SemantucKernel.Plugins.Chat`. - The `LengthByTokenCount` function from `ILengthFunctions` mixin interface in `Encamina.Enmarcha.SemanticKernel.Abstractions` now uses `SharpToken` instead of the `GPT3Tokenizer` class which has been removed from Semantic Kernel. - Added a new length by tokens function called `LengthByTokenCountUsingEncoding` in the `ILengthFunctions` mixin interface. - Removed extension method `ValidateAndThrowIfErrorOccurred` since the properties `ErrorOccurred` and `LastException` are removed from `SKContext` in the new version of Semantic Kernel. This is a breaking change. - Some boy scouting.
…g NuGet packages of these projects.
…SemanticKernel.Connectors.Memory` to add a semantic text memory (i.e., `ISemanticTextMemory`) to the dependency container.
…from `Encamina.Enmarcha.SemanticKernel` to `Encamina.Enmarcha.SemanticKernel.Abstractions`.
rliberoff
changed the title
6.0.4 which updates Semantic Kernel to 1.0.0-beta8
LuisM000
reviewed
Nov 30, 2023
src/Encamina.Enmarcha.SemanticKernel.Connectors.Document/Connectors/TxtDocumentConnector.cs
Outdated
Show resolved
Hide resolved
LuisM000
reviewed
Nov 30, 2023
...ncamina.Enmarcha.SemanticKernel.Connectors.Memory/Extensions/IServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
LuisM000
reviewed
Nov 30, 2023
src/Encamina.Enmarcha.SemanticKernel/Extensions/IKernelExtensions.cs
Outdated
Show resolved
Hide resolved
…rcha.SemanticKernel.Connectors.Document`.
LuisM000
approved these changes
Nov 30, 2023
Hiunkeru
reviewed
Nov 30, 2023
...s/SemanticKernel/Encamina.Enmarcha.Samples.SemanticKernel.QuestionAnswering/appsettings.json
Outdated
Show resolved
Hide resolved
Hiunkeru
reviewed
Nov 30, 2023
| /// </summary> | ||
| public static Func<string, int> LengthByTokenCount => (text) => string.IsNullOrEmpty(text) ? 0 : GPT3Tokenizer.Encode(text).Count; | ||
| /// <seealso href="https://platform.openai.com/tokenizer"/> | ||
| public static Func<string, int> LengthByTokenCount => (text) => string.IsNullOrEmpty(text) ? 0 : GptEncoding.GetEncoding("cl100k_base").Encode(text).Count; |
There was a problem hiding this comment.
I'll leave you a URL that can help you understand the token model. https://github.com/openai/openai-cookbook/blob/main/examples/How_to_count_tokens_with_tiktoken.ipynb
There was a problem hiding this comment.
Good idea. I added it as another seealso.
…ernel.QuestionAnswering` sample.
…ons` on `Encamina.Enmarcha.SemanticKernel.Abstractions`.
Hiunkeru
approved these changes
Nov 30, 2023
Davos95
approved these changes
Nov 30, 2023
BpdcEncaTeam
approved these changes
Dec 1, 2023
fjbelizon
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.20.230821.4-previewto version1.0.0-beta8.6.0.3.20to6.0.4.0NotSemanticFunctionexception message since nowSemantic Kerneldoes not longer differentiates between Semantic and Native functions. Also theArgumentExceptionis not thrown anymore. This affects the following methods:ImportQuestionAnsweringPluginfromEncamina.Enmarcha.SemanticKernel.Plugins.QuestionAnsweringnow expects anISemanticTextMemoryas part of the required services.ImportMemoryPluginfromEncamina.Enmarcha.SemanticKernel.Plugins.Memorynow expects a valid instance ofISemanticTextMemoryas input parameter. This breaks the previous signature of the method.MemoryQueryPluginclass now expects a valid instance ofISemanticTextMemoryinstead ofIKernel. This breaks the previous signature of the class constructor.ChatRequestSettingsis replaced byOpenAIRequestSettingswhich breaks the previous signature of theChatRequestSettingsproperty of theChatWithHistoryPluginOptionsclass inEncamina.Enmarcha.SemantucKernel.Plugins.Chat.LengthByTokenCountfunction fromILengthFunctionsmixin interface inEncamina.Enmarcha.SemanticKernel.Abstractionsnow usesSharpTokeninstead of theGPT3Tokenizerclass which has been removed from Semantic Kernel.LengthByTokenCountUsingEncodingin theILengthFunctionsmixin interface.ValidateAndThrowIfErrorOccurredsince the propertiesErrorOccurredandLastExceptionare removed fromSKContextin the new version of Semantic Kernel. This is a breaking change.Encamina.Enmarcha.SemanticKernel.Connectors.Memoryto add a semantic text memory (i.e.,ISemanticTextMemory) to the dependency container.