Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #34. Semantic kernel summaries plugin fails to preserve the original language of the text #35

Conversation

LuisM000
Copy link
Contributor

  • Introduced a new locale parameter within the config.json file.
  • Incorporated the locale setting into the skprompt.txt file to specified the desired language for the generated summary.

Tests

Request a summary of a text, specifying the locale as 'es-ES', 'en-US', or leaving it unspecified (default is 'en').

Test data

  • Model name: gpt-35-turbo
  • Model version: 0613
  • Input text: Augusta Ada King, condesa de Lovelace (Londres, 10 de diciembre de 1815-íd., 27 de noviembre de 1852), registrada al nacer como Augusta Ada Byron y conocida habitualmente como Ada Lovelace, fue una matemática y escritora británica, célebre sobre todo por su trabajo acerca de la computadora mecánica de uso general de Charles Babbage, la denominada máquina analítica. Fue la primera en reconocer que la máquina tenía aplicaciones más allá del cálculo puro y en haber publicado lo que se reconoce hoy como el primer algoritmo destinado a ser procesado por una máquina, por lo que se le considera como la primera programadora de ordenadores.
    Lovelace fue la única hija legítima del poeta Lord Byron y Anna Isabella Noel Byron. Byron se separó de su esposa un mes después del nacimiento de Ada y dejó Inglaterra para siempre cuatro meses después. Conmemoró la despedida en un poema que comienza: «¿Es tu rostro como el de tu madre, mi bella hija? ¡ADA! Hija única de mi casa y mi corazón».​ Murió en la Guerra de independencia de Grecia cuando Ada tenía ocho años.
    Dedujo y previó la capacidad de los ordenadores para ir más allá de los simples cálculos de números, mientras que otros, incluido el propio Babbage, se centraron únicamente en estas capacidades.
    Su posición social y su educación la llevaron a conocer a científicos importantes como Andrew Crosse, sir David Brewster, Charles Wheatstone, Michael Faraday y al novelista Charles Dickens, relaciones que aprovechó para llegar más lejos en su educación. Entre estas relaciones se encuentra Mary Somerville, que fue su tutora durante un tiempo, además de amiga y estímulo intelectual.​ Ada Byron se refería a sí misma como una científica poetisa y como analista (y metafísica).​

Text extracted from Wikipedia

Test result with locale 'es-ES'

Augusta Ada King, condesa de Lovelace, fue una matemática y escritora británica conocida por su trabajo en la máquina analítica de Charles Babbage. Fue la primera en reconocer las aplicaciones más allá del cálculo puro y publicó el primer algoritmo destinado a ser procesado por una máquina, convirtiéndose en la primera programadora de ordenadores. Lovelace era la única hija legítima del poeta Lord Byron y Anna Isabella Noel Byron. Aunque su padre se separó de su madre poco después de su nacimiento y murió cuando ella tenía ocho años, su posición social y educación le permitieron relacionarse con científicos importantes y ampliar su educación. Ada Byron se refería a sí misma como una científica poetisa y como analista.

Test result with locale 'en-US'

Augusta Ada King, Countess of Lovelace, known as Ada Lovelace, was a British mathematician and writer. She is famous for her work on Charles Babbage's general-purpose mechanical computer, the Analytical Engine. Lovelace was the first to recognize that the machine had applications beyond pure calculation and published what is now recognized as the first algorithm intended to be processed by a machine, making her the first computer programmer. She was the only legitimate daughter of poet Lord Byron and Anna Isabella Noel Byron. Byron separated from his wife a month after Ada's birth and left England forever four months later. He commemorated the farewell in a poem that begins: "Is thy face like thy mother's, my beautiful child? ADA! Sole daughter of my house and heart." She died in the Greek War of Independence when Ada was eight years old. Lovelace deduced and predicted the capabilities of computers to go beyond simple number calculations, while others, including Babbage himself, focused solely on these capabilities. Her social position and education allowed her to meet important scientists such as Andrew Crosse, Sir David Brewster, Charles Wheatstone, Michael Faraday, and novelist Charles Dickens, relationships she used to further her education. One of these relationships was with Mary Somerville, who was her tutor for a time, as well as a friend and intellectual stimulus. Ada Byron referred to herself as a scientific poet and as an analyst (and metaphysician).

Test result without locale

Augusta Ada King, Countess of Lovelace, also known as Ada Lovelace, was a British mathematician and writer. She is best known for her work on Charles Babbage's general-purpose mechanical computer, the Analytical Engine. Lovelace was the first to recognize that the machine had applications beyond pure calculation and is considered the world's first computer programmer for publishing the first algorithm intended to be processed by a machine. She was the only legitimate daughter of poet Lord Byron and Anna Isabella Noel Byron. Lovelace deduced and predicted the capabilities of computers to go beyond simple number calculations, while others, including Babbage himself, focused solely on these capabilities. Her social position and education allowed her to meet important scientists such as Andrew Crosse, Sir David Brewster, Charles Wheatstone, Michael Faraday, and novelist Charles Dickens, relationships she used to further her education. One of these relationships was with Mary Somerville, who was her tutor and intellectual stimulus. Ada Byron referred to herself as a scientific poet and as an analyst (and metaphysician).

@LuisM000 LuisM000 changed the title @lmarcos/issue #34 semantic kernel summaries plugin fails to preserve the original language of the text Issue #34 semantic kernel summaries plugin fails to preserve the original language of the text Dec 20, 2023
@LuisM000 LuisM000 changed the title Issue #34 semantic kernel summaries plugin fails to preserve the original language of the text Issue #34. Semantic kernel summaries plugin fails to preserve the original language of the text Dec 20, 2023
@LuisM000 LuisM000 marked this pull request as ready for review December 20, 2023 07:55
@rliberoff rliberoff added bug Something isn't working enhancement New feature or request labels Dec 21, 2023
@rliberoff rliberoff self-requested a review December 21, 2023 14:20
@LuisM000 LuisM000 merged commit eafc17d into main Dec 21, 2023
6 checks passed
@LuisM000 LuisM000 deleted the @lmarcos/issue-#34-semantic-kernel-summaries-plugin-fails-to-preserve-the-original-language-of-the-text branch December 21, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic Kernel Summaries Plugin fails to preserve the original language of the text
2 participants