Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Axios error handling to print response data if it exists and fix dist check action #22

Merged
merged 4 commits into from
May 3, 2024
Merged

Improve Axios error handling to print response data if it exists and fix dist check action #22

merged 4 commits into from
May 3, 2024

Conversation

andrew-corbalt
Copy link

@andrew-corbalt andrew-corbalt commented May 3, 2024 •
edited
Loading

Improve Axios error handling to print response data if it exists
Fix dist check github action

Tests

  • Ran against cost-analysis code base which is currently having issues, the additional response data was printed
  • Committed uncompiled javascript and verified that dist check github action caught it

@andrew-corbalt andrew-corbalt changed the title Improve Axios error handling to print response data if it exists Improve Axios error handling to print response data if it exists and fix dist check action May 3, 2024
@andrew-corbalt andrew-corbalt merged commit 517ff2a into v2 May 3, 2024
1 check passed
@andrew-corbalt andrew-corbalt deleted the acremins-improve-axios-errors branch May 3, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslie-corbalt leslie-corbalt Awaiting requested review from leslie-corbalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrew-corbalt