Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): address banner not showing up on package actions page #957

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): address banner not showing up on package actions page #957

wants to merge 1 commit into from

Conversation

asharonbaltazar
Copy link
Collaborator

🎫 Linked Ticket

OY2-32046

🛠 Changes

  • remove setTimeout band-aids from previous fix
  • adjust logic to monitor before/after pathname values

13bfrancis
13bfrancis approved these changes Dec 26, 2024
View reviewed changes
Copy link
Collaborator

@13bfrancis 13bfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@asharonbaltazar
Copy link
Collaborator Author

Screen.Recording.2024-12-26.at.2.55.39.PM.mov

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.15% 6480 / 8622
🔵 Statements 74.39% 6806 / 9148
🔵 Functions 69.75% 1958 / 2807
🔵 Branches 42.54% 1215 / 2856
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/ActionForm/index.tsx 94.59% 85.29% 88.88% 94.44% 276-277
react-app/src/components/Banner/banner.tsx 100% 83.33% 100% 100%
Generated in workflow #1209 for commit 0b22de2 by the Vitest Coverage Report Action

@asharonbaltazar asharonbaltazar deployed to fix-banner-package December 26, 2024 20:01 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@13bfrancis 13bfrancis 13bfrancis approved these changes

@charmcitygavin charmcitygavin Awaiting requested review from charmcitygavin

@tiffanyvu tiffanyvu Awaiting requested review from tiffanyvu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asharonbaltazar @13bfrancis