feat(ui): Remove status date in package details for CMS users #965
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbolt
requested review from
thetif,
charmcitygavin,
13bfrancis,
asharonbaltazar and
tiffanyvu
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date-app
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date-kibana
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
asharonbaltazar
approved these changes
Jan 2, 2025
tiffanyvu
approved these changes
Jan 2, 2025
|
@tbolt Should we ask Brian on whether we should remove this property altogether? Is it used anywhere? etc etc |
tbolt
had a problem deploying
to
remove-status-date
GitHub Actions
Failure
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date-app
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date-kibana
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
|
@13bfrancis Can you take a look at this PR? As far as I can tell this is targeted to only remove the status date from rendering on the relevant package details pages. Do you know if this will have any impact outside of those pages? |
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
tbolt
temporarily deployed
to
remove-status-date
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Linked Ticket
OY2-31290
💬 Description / Notes
🛠 Changes
Updates
recordDetailsto no longer have the "Status Date" as an object to be renderedmacpro-mako/react-app/src/features/package/package-details/hooks.tsx
Line 126 in d4b2070