Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): attempt to fix setupIndex test #969

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

asharonbaltazar
Copy link
Collaborator

💬 Description / Notes

Rework setupIndex test to avoid skipping

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.18% 6537 / 8695
🔵 Statements 74.4% 6861 / 9221
🔵 Functions 69.3% 1985 / 2864
🔵 Branches 42.86% 1226 / 2860
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/setupIndex.test.ts 100% 100% 100% 100%
Generated in workflow #1308 for commit 156f143 by the Vitest Coverage Report Action

Copy link
Collaborator

@tbolt tbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did we want to update the titles to match the style of others or is this one OK? Thinking about it now I think I like all lowercase with the style of "[function/class/object/file/etc] should do X"

Screenshot 2025-01-03 at 10 05 33 AM

@asharonbaltazar
Copy link
Collaborator Author

I just updated the tests – didn't want to touch anything else :)

@asharonbaltazar asharonbaltazar merged commit 0625112 into main Jan 3, 2025
30 of 31 checks passed
@asharonbaltazar asharonbaltazar deleted the fix-setup-test branch January 3, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants