skip test that was skipped before #139478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 462ad0e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (0.0% change). View more on Code Climate. |
BearHanded
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tried fixing this test but didn't have much luck then I realized this was skipped before the cypress update (see
ignoreTestFilesin the old cypress.json) so let's continue skipping it for now while we figure out better tests in a separate ticketWill "fix" our woes with the e2e tests failing in main and val
Related ticket(s)
MDCT-2806 kinda
How to test
In cypress.config.ts modify
baseUrlto point athttps://mdctcartsdev.cms.govand run the test suite in ci mode"CYPRESS_ADMIN_USER_PASSWORD=pw CYPRESS_STATE_USER_PASSWORD=pwQ yarn test:ci"(replacing pw with the carts test user password)Verify they all pass and filterReports is skipped
Author checklist