Minor content changes for 2023

[benmartin-coforma]

Description

1. Add calculation explanation to Section 2, Part 1: "Number of Children enrolled in CHIP"
2. Remove past years from Section 2, Part 2. It only needs to go back 5 years, so for 2023, going back to 2018 is sufficient.
3. Add "Part 1" and "Part 2" headers to Section 3I. This is tricky and maybe not the best solution, but Part.js line 55 prevents these headers from displaying unless the part has a title. I don't have any text to add for the title but I can add an invisible truthy string: U+00A0, the non-breaking space. This causes the headers to render as Part 1: and Part 2:. If the trailing colon is not desirable, then this request will require a broader change.
4. Change repeatable question text in Section 3I to "Does the state have additional HSIs to report?". This required a schema change to optionally pass in this text. I don't believe it will affect any other questions.
5. Change repeatable button text in Section 3I to "Add Another HSI Program". The requested text was "Add Another HSI", but the JSON already had "typeLabel": "HSI Program", and an apparent bug: it seems like it was always intended for this text to pass through to the button text. Additionally, it seems like it was always intended to pass this through to the "do you have another" question text, as well as the "delete last" button text. I've "fixed" it here, but THIS MAY NOT BE A GOOD IDEA, as it will affect all repeatables throughout the report. This includes all six repeatables in Section 4, which will now ask "Do you have another Goal in this list?" with button text "Add another Goal".
6. Hide the "Optional" text under "Does the state have additional HSIs to report?". This was another schema change, to optionally pass a hideOptionalHint flag through the question.

Related ticket(s)

MDCT-3035

---

How to test

1. Log in to CARTS as an admin
2. Generate the 2023 forms
3. Log in to CARTS as a state user
4. Click through the report to observe the changes

Important updates

n/a

---

Author checklist

• I have performed a self-review of my code
• I have added thorough tests, if necessary
• I have updated relevant documentation, if necessary

[BearHanded]

Add "Part 1" and "Part 2" headers to Section 3I. ... If the trailing colon is not desirable, then this request will require a broader change.

This one I could go either way on, if only due to timing. My guess is the trailing colon will be fine. It's worth running by David, though.

[gmrabian]

We want to hide the 'optional' hint, right?
Otherwise changes look good. I verified the trailing colon and non-breaking space don't have any issues when read with VoiceOver (It just says "Part 1" and moves on)

[codeclimate]

Code Climate has analyzed commit a5addc8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.2% change).

View more on Code Climate.