Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in slack changes for CARTS #139600

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Adding in slack changes for CARTS #139600

merged 2 commits into from
Apr 9, 2024

Conversation

dwhitestratiform
Copy link
Contributor

Description

Current slack notification functionality is noisy and often gives alerts on events we don't particularly care about and omits events that we do care about. This aims to fix that by doing the following.

macpro-mdct-carts-alerts, mdct-prod-releases, and mdct-integrations-channel have all been created in cms slack
webhooks have been requested, created, and populated into github secrets for the SEDS repository
following standards the webhooks were also populated into the carts aws ssm account (readme for this is also updated as part of this PR)
webhooks were implemented to alert on the following things
new pr creation - alerts to the mdct-integrations-channel
failed builds of main, val, or prod - alerts to the macpro-mdct-carts-alerts channel
failed snyk auto merges - alerts to mdct-integrations-channel
release to production - alerts to the mdct-prod-releases channel

Related ticket(s)

https://jiraent.cms.gov/browse/CMDCT-3428


How to test

merge and watch for issues. this has already been tested in seds.

Notes

once we get all the products done, we'll move everyone over to the new channels but that should be fast after the first one of these goes through and is tested


Pre-review checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

berryd
berryd previously approved these changes Apr 8, 2024
@dwhitestratiform
Copy link
Contributor Author

using branch permissions to merge to integration branch as this is a skip-ci branch it'll never pass all pr checks because no infra is deployed.

@dwhitestratiform dwhitestratiform merged commit 77944c8 into main Apr 9, 2024
12 checks passed
@dwhitestratiform dwhitestratiform deleted the skipci-slack-changes branch April 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants